Changeset 53247

Timestamp:

04/24/2022 09:01:09 PM (3 years ago)

Author:

audrasjb

Message:

Twenty Fifteen: Use #page height instead of body height in sidebar scroll calculation.

This changeset replaces bodyHeight = $body.height(); with bodyHeight = $('#page).height();. It fixes a JS issue in some specific context, when there is content generated right before the closing body tag. For example, this happens when the HTML content is added using the wp_footer filter.

Props stephenharris, sabernhardt, audrasjb.
Fixes #40492.

File:

• trunk/src/wp-content/themes/twentyfifteen/js/functions.js (modified) (1 diff)

trunk/src/wp-content/themes/twentyfifteen/js/functions.js

@@ -100 +100 @@
             windowHeight = $window.height(),
             sidebarHeight = $sidebar.height(),
-            bodyHeight = $body.height();
+            pageHeight = $( '#page' ).height();
 
-        if( 955 < $window.width() && bodyHeight > sidebarHeight && ( windowPos + windowHeight ) >= sidebarHeight ) {
+        if ( 955 < $window.width() && pageHeight > sidebarHeight && ( windowPos + windowHeight ) >= sidebarHeight ) {
             $sidebar.css({
                 position: 'fixed',