Changeset 53264

Timestamp:

04/26/2022 02:57:22 AM (4 years ago)

Author:

peterwilsoncc

Message:

Administration: Trigger a notice for incorrect add_menu_page() parameter.

Trigger a notice (via _doing_it_wrong()) for developers incorrectly setting the position when calling add_menu_page().

Modify a similar message in add_submenu_page() to combine near identical strings and match the error description to the conditions in which it is called.

Follow up to [52569], [53104].

Fixes #40927.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (2 diffs)

trunk/src/wp-admin/includes/plugin.php

@@ -1326 +1326 @@
         $new_menu = array( $menu_title, $capability, $menu_slug, $page_title, 'menu-top ' . $icon_class . $hookname, $hookname, $icon_url );
 
+        if ( null !== $position && ! is_numeric( $position ) ) {
+                _doing_it_wrong(
+                        __FUNCTION__,
+                        sprintf(
+                                /* translators: %s: add_menu_page() */
+                                __( 'The seventh parameter passed to %s should be numeric representing menu position.' ),
+                                '<code>add_menu_page()</code>'
+                        ),
+                        '6.0.0'
+                );
+                $position = null;
+        }
+
         if ( null === $position || ! is_numeric( $position ) ) {
                 $menu[] = $new_menu;
@@ -1422 +1435 @@
                         sprintf(
                                 /* translators: %s: add_submenu_page() */
-                                __( 'The seventh parameter passed to %s should be an integer representing menu position.' ),
+                                __( 'The seventh parameter passed to %s should be numeric representing menu position.' ),
                                 '<code>add_submenu_page()</code>'
                         ),