Make WordPress Core

Changeset 53269


Ignore:
Timestamp:
04/26/2022 09:58:23 AM (2 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/class-wp-embed.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $match parameter to $matches in WP_Embed::autoembed_callback().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-wp-embed.php

    r53046 r53269  
    455455     * Callback function for WP_Embed::autoembed().
    456456     *
    457      * @param array $match A regex match array.
     457     * @param array $matches A regex match array.
    458458     * @return string The embed HTML on success, otherwise the original URL.
    459459     */
    460     public function autoembed_callback( $match ) {
     460    public function autoembed_callback( $matches ) {
    461461        $oldval              = $this->linkifunknown;
    462462        $this->linkifunknown = false;
    463         $return              = $this->shortcode( array(), $match[2] );
     463        $return              = $this->shortcode( array(), $matches[2] );
    464464        $this->linkifunknown = $oldval;
    465465
    466         return $match[1] . $return . $match[3];
     466        return $matches[1] . $return . $matches[3];
    467467    }
    468468
Note: See TracChangeset for help on using the changeset viewer.