Changeset 53269 for trunk/src/wp-includes/class-wp-embed.php

Timestamp:

04/26/2022 09:58:23 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/class-wp-embed.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $match parameter to $matches in WP_Embed::autoembed_callback().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:

• trunk/src/wp-includes/class-wp-embed.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-embed.php

@@ -455 +455 @@
      * Callback function for WP_Embed::autoembed().
      *
-     * @param array $match A regex match array.
+     * @param array $matches A regex match array.
      * @return string The embed HTML on success, otherwise the original URL.
      */
-    public function autoembed_callback( $match ) {
+    public function autoembed_callback( $matches ) {
         $oldval              = $this->linkifunknown;
         $this->linkifunknown = false;
-        $return              = $this->shortcode( array(), $match[2] );
+        $return              = $this->shortcode( array(), $matches[2] );
         $this->linkifunknown = $oldval;
 
-        return $match[1] . $return . $match[3];
+        return $matches[1] . $return . $matches[3];
     }