Make WordPress Core


Ignore:
Timestamp:
04/26/2022 11:23:59 AM (2 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/class-wp-image-editor-gd.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $function parameter to $callback in WP_Image_Editor_GD::make_image().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-wp-image-editor-gd.php

    r52978 r53270  
    538538     *
    539539     * @param string   $filename
    540      * @param callable $function
     540     * @param callable $callback
    541541     * @param array    $arguments
    542542     * @return bool
    543543     */
    544     protected function make_image( $filename, $function, $arguments ) {
     544    protected function make_image( $filename, $callback, $arguments ) {
    545545        if ( wp_is_stream( $filename ) ) {
    546546            $arguments[1] = null;
    547547        }
    548548
    549         return parent::make_image( $filename, $function, $arguments );
     549        return parent::make_image( $filename, $callback, $arguments );
    550550    }
    551551}
Note: See TracChangeset for help on using the changeset viewer.