Make WordPress Core

Changeset 53275


Ignore:
Timestamp:
04/26/2022 11:42:37 AM (2 years ago)
Author:
SergeyBiryukov
Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/class-wp-term-query.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $string parameter to $search in WP_Term_Query::get_search_sql().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/class-wp-term-query.php

    r53175 r53275  
    10691069     * @global wpdb $wpdb WordPress database abstraction object.
    10701070     *
    1071      * @param string $string
     1071     * @param string $search
    10721072     * @return string
    10731073     */
    1074     protected function get_search_sql( $string ) {
     1074    protected function get_search_sql( $search ) {
    10751075        global $wpdb;
    10761076
    1077         $like = '%' . $wpdb->esc_like( $string ) . '%';
     1077        $like = '%' . $wpdb->esc_like( $search ) . '%';
    10781078
    10791079        return $wpdb->prepare( '((t.name LIKE %s) OR (t.slug LIKE %s))', $like, $like );
Note: See TracChangeset for help on using the changeset viewer.