Changeset 53281

Timestamp:

04/26/2022 02:26:38 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Rename parameters that use reserved keywords in wp-includes/class-wp-query.php.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the $list parameter to $status in WP_Dependencies::query().

Follow-up to [52946], [52996], [52997], [52998], [53003], [53014], [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185], [53192], [53193], [53198], [53203], [53207], [53215], [53216], [53220], [53230], [53232], [53236], [53239], [53240], [53242], [53243], [53245], [53246], [53257], [53269], [53270], [53271], [53272], [53273], [53274], [53275], [53276], [53277].

Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
See #55327.

File:

• trunk/src/wp-includes/class.wp-dependencies.php (modified) (4 diffs)

trunk/src/wp-includes/class.wp-dependencies.php

@@ -432 +432 @@
 
     /**
-     * Query list for an item.
+     * Query the list for an item.
      *
      * @since 2.1.0
@@ -438 +438 @@
      *
      * @param string $handle Name of the item. Should be unique.
-     * @param string $list   Optional. Property name of list array. Default 'registered'.
+     * @param string $status Optional. Status of the item to query. Default 'registered'.
      * @return bool|_WP_Dependency Found, or object Item data.
      */
-    public function query( $handle, $list = 'registered' ) {
-        switch ( $list ) {
+    public function query( $handle, $status = 'registered' ) {
+        switch ( $status ) {
             case 'registered':
             case 'scripts': // Back compat.
@@ -451 +451 @@
 
             case 'enqueued':
-            case 'queue':
+            case 'queue': // Back compat.
                 if ( in_array( $handle, $this->queue, true ) ) {
                     return true;
@@ -465 +465 @@
                 return in_array( $handle, $this->done, true );
         }
+
         return false;
     }