Changeset 53294

Timestamp:

04/27/2022 01:45:57 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Bootstrap/Load: Avoid a PHP warning when setting the $pagenow global in wp-includes/vars.php.

In some scenarios where is_admin() returns true but $_SERVER['PHP_SELF'] does not match a wp-admin/* location, setting the $pagenow global could trigger a PHP warning: Undefined array key 1.

This commit avoids the warning by checking whether the matches array is not empty.

Props janh2, konradyoast, peterwilsoncc.
Fixes #54700.

File:

• trunk/src/wp-includes/vars.php (modified) (1 diff)

trunk/src/wp-includes/vars.php

@@ -30 +30 @@
         preg_match( '#/wp-admin/?(.*?)$#i', $_SERVER['PHP_SELF'], $self_matches );
     }
-    $pagenow = $self_matches[1];
+
+    $pagenow = ! empty( $self_matches[1] ) ? $self_matches[1] : '';
     $pagenow = trim( $pagenow, '/' );
     $pagenow = preg_replace( '#\?.*?$#', '', $pagenow );
+
     if ( '' === $pagenow || 'index' === $pagenow || 'index.php' === $pagenow ) {
         $pagenow = 'index.php';