Context Navigation

← Previous Change
Next Change →

class-wp-user-query.php

Timestamp:

05/02/2022 12:11:48 AM (4 years ago)

Author:

peterwilsoncc

Message:

Users: Validate WP_User_Query's fields argument.

Improve validation of WP_User_Query's fields argument when passed as an array to ensure it only accepts permitted values. This prevents the invalid values being included in the generated database query.

Expand unit tests to include passing invalid values as part of an array, the lower case value id. Correct earlier unit tests to limit database query to one result.

Follow up to [53255].

Props felipeelia.
Fixes #53177.

File:

: 1 edited

trunk/src/wp-includes/class-wp-user-query.php (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-includes/class-wp-user-query.php

-              r53280
+              r53327
                 if ( is_array( $qv['fields'] ) ) {
+                        $qv['fields'] = array_unique( $qv['fields'] );
+                        $qv['fields'] = array_intersect( array_unique( $qv['fields'] ), $allowed_fields );
+                        if ( empty( $qv['fields'] ) ) {
+                                $qv['fields'] = array( 'ID' );
+                        }
                         $this->query_fields = array();
 …
+                        }
                         $this->query_fields = implode( ',', $this->query_fields );
+                } elseif ( 'all' === $qv['fields'] ) {
+                        $this->query_fields = "$wpdb->users.*";
                 } elseif ( ! in_array( $qv['fields'], $allowed_fields, true ) ) {
                         $this->query_fields = "$wpdb->users.*";
+                        $this->query_fields = "$wpdb->users.ID";
                 } else {
                         $field              = 'ID' === $qv['fields'] ? 'ID' : sanitize_key( $qv['fields'] );

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 53327 for trunk/src/wp-includes/class-wp-user-query.php

Legend:

trunk/src/wp-includes/class-wp-user-query.php

Download in other formats: