Changeset 53361

Timestamp:

05/07/2022 03:08:24 AM (2 years ago)

Author:

peterwilsoncc

Message:

Quick/Bulk Edit: Remove duplicate HTML IDs.

Rename #inline-edit-legend to avoid duplicate HTML IDs. These have been renamed #quick-edit-legend and #bulk-edit-legend for the quick and bulk editors respectively.

This HTML ID is not required by the quick editor duplicated via JavaScript so is removed as part of the duplication process.

Follow up to [53096].

Props azaozz, costdev, greglone, hellofromtonya, ironprogrammer, joedolson, sabernhardt, SergeyBiryukov, audrasjb.
Merges [53352] to the 6.0 branch.
Fixes #55575.
See #35483.

Location:

branches/6.0

Files:

• . (modified) (1 prop)
• src/js/_enqueues/admin/inline-edit-post.js (modified) (1 diff)
• src/wp-admin/includes/class-wp-posts-list-table.php (modified) (1 diff)

branches/6.0/src/js/_enqueues/admin/inline-edit-post.js

@@ -294 +294 @@
         editRow = $('#inline-edit').clone(true);
         $( 'td', editRow ).attr( 'colspan', $( 'th:visible, td:visible', '.widefat:first thead' ).length );
+
+        // Remove the ID from the copied row and let the `for` attribute reference the hidden ID.
+        $( 'td', editRow ).find('#quick-edit-legend').removeAttr('id');
+        $( 'td', editRow ).find('p[id^="quick-edit-"]').removeAttr('id');
 
         $(t.what+id).removeClass('is-expanded').hide().after(editRow).after('<tr class="hidden"></tr>');

branches/6.0/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1612 +1612 @@
             <tr id="<?php echo $bulk ? 'bulk-edit' : 'inline-edit'; ?>" class="<?php echo $classes; ?>" style="display: none">
             <td colspan="<?php echo $this->get_column_count(); ?>" class="colspanchange">
-            <div class="inline-edit-wrapper" role="region" aria-labelledby="inline-edit-legend">
+            <div class="inline-edit-wrapper" role="region" aria-labelledby="<?php echo $bulk ? 'bulk' : 'quick'; ?>-edit-legend">
             <fieldset class="inline-edit-col-left">
-                <legend class="inline-edit-legend" id="inline-edit-legend"><?php echo $bulk ? __( 'Bulk Edit' ) : __( 'Quick Edit' ); ?></legend>
+                <legend class="inline-edit-legend" id="<?php echo $bulk ? 'bulk' : 'quick'; ?>-edit-legend"><?php echo $bulk ? __( 'Bulk Edit' ) : __( 'Quick Edit' ); ?></legend>
                 <div class="inline-edit-col">