Changeset 53375

Timestamp:

05/10/2022 11:15:28 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Restore the $pieces variable in WP_Query::get_posts().

This is a defensive coding measure that aims to reduce confusion. With this change, $pieces is explicitly used for the names, and $clauses for the values of the clauses.

Follow-up to [52974], [53175], [53370].

Props peterwilsoncc.
See #55699.

File:

• trunk/src/wp-includes/class-wp-query.php (modified) (5 diffs)

trunk/src/wp-includes/class-wp-query.php

@@ -2755 +2755 @@
         }
 
+        $pieces = array( 'where', 'groupby', 'join', 'orderby', 'distinct', 'fields', 'limits' );
+
         /*
          * Apply post-paging filters on where and join. Only plugins that
@@ -2833 +2835 @@
              */
             $fields = apply_filters_ref_array( 'posts_fields', array( $fields, &$this ) );
-
-            $clauses = array( 'where', 'groupby', 'join', 'orderby', 'distinct', 'fields', 'limits' );
 
             /**
@@ -2857 +2857 @@
              * @param WP_Query $query   The WP_Query instance (passed by reference).
              */
-            $clauses = (array) apply_filters_ref_array( 'posts_clauses', array( compact( $clauses ), &$this ) );
+            $clauses = (array) apply_filters_ref_array( 'posts_clauses', array( compact( $pieces ), &$this ) );
 
             $where    = isset( $clauses['where'] ) ? $clauses['where'] : '';
@@ -2968 +2968 @@
             $limits = apply_filters_ref_array( 'post_limits_request', array( $limits, &$this ) );
 
-            $clauses = array( 'where', 'groupby', 'join', 'orderby', 'distinct', 'fields', 'limits' );
-
             /**
              * Filters all query clauses at once, for convenience.
@@ -2993 +2991 @@
              * @param WP_Query $query  The WP_Query instance (passed by reference).
              */
-            $clauses = (array) apply_filters_ref_array( 'posts_clauses_request', array( compact( $clauses ), &$this ) );
+            $clauses = (array) apply_filters_ref_array( 'posts_clauses_request', array( compact( $pieces ), &$this ) );
 
             $where    = isset( $clauses['where'] ) ? $clauses['where'] : '';