Changeset 53376 for trunk/src/wp-includes/class-wp-comment-query.php

Timestamp:

05/10/2022 11:19:51 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Restore the $pieces variable for SQL clauses in query classes.

This is a defensive coding measure that aims to reduce confusion. With this change, $pieces is explicitly used for the names, and $clauses for the values of the clauses.

Follow-up to [52974], [53175], [53370], [53375].

Props peterwilsoncc.
See #55699.

File:

• trunk/src/wp-includes/class-wp-comment-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -918 +918 @@
         $where = implode( ' AND ', $this->sql_clauses['where'] );
 
-        $clauses = array( 'fields', 'join', 'where', 'orderby', 'limits', 'groupby' );
+        $pieces = array( 'fields', 'join', 'where', 'orderby', 'limits', 'groupby' );
 
         /**
@@ -928 +928 @@
          * @param WP_Comment_Query $query   Current instance of WP_Comment_Query (passed by reference).
          */
-        $clauses = apply_filters_ref_array( 'comments_clauses', array( compact( $clauses ), &$this ) );
+        $clauses = apply_filters_ref_array( 'comments_clauses', array( compact( $pieces ), &$this ) );
 
         $fields  = isset( $clauses['fields'] ) ? $clauses['fields'] : '';