Changeset 53376 for trunk/src/wp-includes/class-wp-term-query.php

Timestamp:

05/10/2022 11:19:51 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Restore the $pieces variable for SQL clauses in query classes.

This is a defensive coding measure that aims to reduce confusion. With this change, $pieces is explicitly used for the names, and $clauses for the values of the clauses.

Follow-up to [52974], [53175], [53370], [53375].

Props peterwilsoncc.
See #55699.

File:

• trunk/src/wp-includes/class-wp-term-query.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-term-query.php

@@ -701 +701 @@
         $where = implode( ' AND ', $this->sql_clauses['where'] );
 
-        $clauses = array( 'fields', 'join', 'where', 'distinct', 'orderby', 'order', 'limits' );
+        $pieces = array( 'fields', 'join', 'where', 'distinct', 'orderby', 'order', 'limits' );
 
         /**
@@ -722 +722 @@
          * @param array    $args       An array of term query arguments.
          */
-        $clauses = apply_filters( 'terms_clauses', compact( $clauses ), $taxonomies, $args );
+        $clauses = apply_filters( 'terms_clauses', compact( $pieces ), $taxonomies, $args );
 
         $fields   = isset( $clauses['fields'] ) ? $clauses['fields'] : '';