Changeset 53389

Timestamp:

05/10/2022 09:40:16 PM (3 years ago)

Author:

hellofromTonya

Message:

Editor: Use stricter assertions in comment template tests.

Backport of the remaining Comment Template block tests from Gutenberg:

• assertEquals() replaced with assertSameSetsWithIndex().
• assertion's argument order changed to ensure expected and then actual.

Follow-up to [53353], [53298], [53172], [53138].

Props bernhard-reiter.
Merges [53388] to the 6.0 branch.
Fixes #55708.

Location:

branches/6.0

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/blocks/renderCommentTemplate.php (modified) (4 diffs)

branches/6.0/tests/phpunit/tests/blocks/renderCommentTemplate.php

@@ -67 +67 @@
         );
 
-        $this->assertEquals(
+        $this->assertSameSetsWithIndex(
             array(
                 'orderby'       => 'comment_date_gmt',
@@ -124 +124 @@
         $block = new WP_Block( $parsed_blocks[0] );
 
-        $this->assertEquals(
+        $this->assertSameSetsWithIndex(
             array(
                 'orderby'       => 'comment_date_gmt',
@@ -390 +390 @@
         add_filter( 'wp_get_current_commenter', $commenter_filter );
 
-        $this->assertEquals(
-            build_comment_query_vars_from_block( $block ),
+        $this->assertSameSetsWithIndex(
             array(
                 'orderby'            => 'comment_date_gmt',
@@ -402 +401 @@
                 'number'             => 5,
                 'paged'              => 1,
-            )
+            ),
+            build_comment_query_vars_from_block( $block )
         );
     }