Changeset 53396

Timestamp:

05/15/2022 03:55:11 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Expand the test for conditional tags returning early if $wp_query is not set.

When called too early, conditional query tags should throw a _doing_it_wrong() notice and return false. This commit verifies that behavior not only for is_main_query(), but for all the other conditional tags too.

Follow-up to [16947], [17068], [17083], [18699], [37985], [53395].

See #55104.

File:

• trunk/tests/phpunit/tests/query/conditionals.php (modified) (1 diff)

trunk/tests/phpunit/tests/query/conditionals.php

@@ -1619 +1619 @@
         /**
          * @ticket 55104
-         * @expectedIncorrectUsage is_main_query
-         */
-        public function test_is_main_query_returns_false_if_wp_query_is_not_set() {
+         */
+        public function test_conditional_tags_trigger_doing_it_wrong_and_return_false_if_wp_query_is_not_set() {
                 unset( $GLOBALS['wp_query'] );
 
-                $this->assertFalse( is_main_query() );
+                $functions = get_class_methods( 'WP_Query' );
+
+                foreach ( $functions as $function_name ) {
+                        // Only test `is_*()` conditional tags.
+                        if ( ! str_starts_with( $function_name, 'is_' ) ) {
+                                continue;
+                        }
+
+                        if ( 'is_comments_popup' === $function_name ) {
+                                // `is_comments_popup()` is deprecated as of WP 4.5.
+                                $this->setExpectedDeprecated( $function_name );
+                        } else {
+                                // All the other functions should throw a `_doing_it_wrong()` notice.
+                                $this->setExpectedIncorrectUsage( $function_name );
+                        }
+
+                        $this->assertFalse( call_user_func( $function_name ) );
+                }
         }