Changeset 53400 for trunk/tests/phpunit/tests/query/conditionals.php

Timestamp:

05/16/2022 02:09:41 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use a data provider in the test for conditional tags returning early if $wp_query is not set.

Follow-up to [53395], [53396].

Props peterwilsoncc.
See #55104.

File:

• trunk/tests/phpunit/tests/query/conditionals.php (modified) (1 diff)

trunk/tests/phpunit/tests/query/conditionals.php

@@ -1619 +1619 @@
         /**
          * @ticket 55104
-         */
-        public function test_conditional_tags_trigger_doing_it_wrong_and_return_false_if_wp_query_is_not_set() {
+         *
+         * @dataProvider data_conditional_tags_trigger_doing_it_wrong_and_return_false_if_wp_query_is_not_set
+         *
+         * @param string $function_name The name of the function to test.
+         */
+        public function test_conditional_tags_trigger_doing_it_wrong_and_return_false_if_wp_query_is_not_set( $function_name ) {
                 unset( $GLOBALS['wp_query'] );
 
-                $functions = get_class_methods( 'WP_Query' );
-
-                foreach ( $functions as $function_name ) {
-                        // Only test `is_*()` conditional tags.
-                        if ( ! str_starts_with( $function_name, 'is_' ) ) {
-                                continue;
+                if ( 'is_comments_popup' === $function_name ) {
+                        // `is_comments_popup()` is deprecated as of WP 4.5.
+                        $this->setExpectedDeprecated( $function_name );
+                } else {
+                        // All the other functions should throw a `_doing_it_wrong()` notice.
+                        $this->setExpectedIncorrectUsage( $function_name );
+                }
+
+                $this->assertFalse( call_user_func( $function_name ) );
+        }
+
+        /**
+         * Data provider.
+         */
+        public function data_conditional_tags_trigger_doing_it_wrong_and_return_false_if_wp_query_is_not_set() {
+                // Get the list of `is_*()` conditional tags.
+                $functions = array_filter(
+                        get_class_methods( 'WP_Query' ),
+                        static function( $function_name ) {
+                                return str_starts_with( $function_name, 'is_' );
                         }
-
-                        if ( 'is_comments_popup' === $function_name ) {
-                                // `is_comments_popup()` is deprecated as of WP 4.5.
-                                $this->setExpectedDeprecated( $function_name );
-                        } else {
-                                // All the other functions should throw a `_doing_it_wrong()` notice.
-                                $this->setExpectedIncorrectUsage( $function_name );
-                        }
-
-                        $this->assertFalse( call_user_func( $function_name ) );
-                }
+                );
+
+                // Wrap each function name in an array.
+                $functions = array_map(
+                        static function( $function_name ) {
+                                return array( $function_name );
+                        },
+                        $functions
+                );
+
+                return $functions;
         }