Changeset 53408 for trunk/tests/phpunit/tests/user.php

Timestamp:

05/17/2022 06:59:24 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Users: Fail gracefully when checking mapped capabilities without providing the required object ID.

This avoids an Undefined array key 0 PHP warning for current_user_can() capability checks that require a specific object to check against but an object ID was not passed.

A _doing_it_wrong() notice is also added, so that developers and site administrators are aware that the capability mapping is failing in the absence of the required object ID.

The list of mapped capabilities that require an object ID:

• delete_post / delete_page
• edit_post / edit_page
• read_post / read_page
• publish_post
• edit_(post|comment|term|user)_meta / delete_*_meta / add_*_meta
• edit_comment
• edit_term / delete_term / assign_term

Follow-up to [34091], [34113], [47178].

Props jeherve, peterwilsoncc, henry.wright, johnbillion, mattheweppelsheimer, hellofromTonya, JeffPaul, azouamauriac, Ninos Ego, TobiasBg, wpsmith, GaryJ, nacin, johnstonphilip, azaozz, SergeyBiryukov.
Fixes #44591.

File:

• trunk/tests/phpunit/tests/user.php (modified) (1 diff)

trunk/tests/phpunit/tests/user.php

@@ -1975 +1975 @@
         );
 
-        // _doing_wrong() should be called because the filter callback
+        // _doing_it_wrong() should be called because the filter callback
         // adds a item with a 'name' that is the same as one generated by core.
         $this->setExpectedIncorrectUsage( 'wp_user_personal_data_exporter' );