Changeset 53408 for trunk/tests/phpunit/tests/user/mapMetaCap.php

Timestamp:

05/17/2022 06:59:24 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Users: Fail gracefully when checking mapped capabilities without providing the required object ID.

This avoids an Undefined array key 0 PHP warning for current_user_can() capability checks that require a specific object to check against but an object ID was not passed.

A _doing_it_wrong() notice is also added, so that developers and site administrators are aware that the capability mapping is failing in the absence of the required object ID.

The list of mapped capabilities that require an object ID:

• delete_post / delete_page
• edit_post / edit_page
• read_post / read_page
• publish_post
• edit_(post|comment|term|user)_meta / delete_*_meta / add_*_meta
• edit_comment
• edit_term / delete_term / assign_term

Follow-up to [34091], [34113], [47178].

Props jeherve, peterwilsoncc, henry.wright, johnbillion, mattheweppelsheimer, hellofromTonya, JeffPaul, azouamauriac, Ninos Ego, TobiasBg, wpsmith, GaryJ, nacin, johnstonphilip, azaozz, SergeyBiryukov.
Fixes #44591.

File:

• trunk/tests/phpunit/tests/user/mapMetaCap.php (modified) (2 diffs)

trunk/tests/phpunit/tests/user/mapMetaCap.php

@@ -4 +4 @@
  * @group user
  * @group capabilities
+ * @covers ::map_meta_cap
  */
 class Tests_User_MapMetaCap extends WP_UnitTestCase {
@@ -411 +412 @@
         $this->assertSame( array( 'manage_options' ), $caps );
     }
+
+    /**
+     * @dataProvider data_meta_caps_throw_doing_it_wrong_without_required_argument_provided
+     * @ticket 44591
+     *
+     * @param string $cap The meta capability requiring an argument.
+     */
+    public function test_meta_caps_throw_doing_it_wrong_without_required_argument_provided( $cap ) {
+        $admin_user = self::$user_id;
+        $this->setExpectedIncorrectUsage( 'map_meta_cap' );
+        $this->assertContains( 'do_not_allow', map_meta_cap( $cap, $admin_user ) );
+    }
+
+    /**
+     * Data provider.
+     *
+     * @return array[] Test parameters {
+     *     @type string $cap The meta capability requiring an argument.
+     * }
+     */
+    public function data_meta_caps_throw_doing_it_wrong_without_required_argument_provided() {
+        return array(
+            array( 'delete_post' ),
+            array( 'delete_page' ),
+            array( 'edit_post' ),
+            array( 'edit_page' ),
+            array( 'read_post' ),
+            array( 'read_page' ),
+            array( 'publish_post' ),
+            array( 'edit_post_meta' ),
+            array( 'delete_post_meta' ),
+            array( 'add_post_meta' ),
+            array( 'edit_comment_meta' ),
+            array( 'delete_comment_meta' ),
+            array( 'add_comment_meta' ),
+            array( 'edit_term_meta' ),
+            array( 'delete_term_meta' ),
+            array( 'add_term_meta' ),
+            array( 'edit_user_meta' ),
+            array( 'delete_user_meta' ),
+            array( 'add_user_meta' ),
+            array( 'edit_comment' ),
+            array( 'edit_term' ),
+            array( 'delete_term' ),
+            array( 'assign_term' ),
+        );
+    }
 }