Changeset 53426 for trunk/src/wp-admin/includes/class-wp-automatic-updater.php

Timestamp:

05/20/2022 05:36:23 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace phpversion() function calls with PHP_VERSION constant.

phpversion() return value and PHP_VERSION constant value are identical, but the latter is several times faster because it is a direct constant value lookup compared to a function call.

Props ayeshrajans, jrf, mukesh27, costdev, hellofromTonya, SergeyBiryukov.
Fixes #55680.

File:

• trunk/src/wp-admin/includes/class-wp-automatic-updater.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-automatic-updater.php

@@ -223 +223 @@
                         global $wpdb;
 
-                        $php_compat = version_compare( phpversion(), $item->php_version, '>=' );
+                        $php_compat = version_compare( PHP_VERSION, $item->php_version, '>=' );
                         if ( file_exists( WP_CONTENT_DIR . '/db.php' ) && empty( $wpdb->is_mysql ) ) {
                                 $mysql_compat = true;
@@ -237 +237 @@
                 // If updating a plugin or theme, ensure the minimum PHP version requirements are satisfied.
                 if ( in_array( $type, array( 'plugin', 'theme' ), true ) ) {
-                        if ( ! empty( $item->requires_php ) && version_compare( phpversion(), $item->requires_php, '<' ) ) {
+                        if ( ! empty( $item->requires_php ) && version_compare( PHP_VERSION, $item->requires_php, '<' ) ) {
                                 return false;
                         }