Changeset 53433 for trunk/tests/phpunit/tests/external-http/basic.php

Timestamp:

05/23/2022 02:07:47 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Improve the assertions in recommended MySQL and MariaDB version tests.

Comparing human-readable dates instead of numeric timestamps gives identical results, but makes the message more clear in case of failure.

Follow-up to [33946], [52418], [52421], [52424].

See #55791, #55652.

File:

• trunk/tests/phpunit/tests/external-http/basic.php (modified) (2 diffs)

trunk/tests/phpunit/tests/external-http/basic.php

@@ -53 +53 @@
          * TODO: Reduce this back to 5 years once MySQL 8.0 compatibility is achieved.
          */
-        $mysql_eol = strtotime( $mysql_matches[1] . ' +8 years' );
+        $mysql_eol    = gmdate( 'Y-m-d', strtotime( $mysql_matches[1] . ' +8 years' ) );
+        $current_date = gmdate( 'Y-m-d' );
 
-        $this->assertLessThan( $mysql_eol, time(), "readme.html's Recommended MySQL version is too old. Remember to update the WordPress.org Requirements page, too." );
+        $this->assertLessThan( $mysql_eol, $current_date, "readme.html's Recommended MySQL version is too old. Remember to update the WordPress.org Requirements page, too." );
     }
 
@@ -85 +86 @@
 
         // Per https://mariadb.org/about/#maintenance-policy, MariaDB releases are supported for 5 years.
-        $mariadb_eol = strtotime( $mariadb_matches[1] . ' +5 years' );
+        $mariadb_eol  = gmdate( 'Y-m-d', strtotime( $mariadb_matches[1] . ' +5 years' ) );
+        $current_date = gmdate( 'Y-m-d' );
 
-        $this->assertLessThan( $mariadb_eol, time(), "readme.html's Recommended MariaDB version is too old. Remember to update the WordPress.org Requirements page, too." );
+        $this->assertLessThan( $mariadb_eol, $current_date, "readme.html's Recommended MariaDB version is too old. Remember to update the WordPress.org Requirements page, too." );
     }