Changeset 53455 for trunk/src/wp-admin/includes/class-custom-background.php

Timestamp:

06/01/2022 06:12:25 PM (4 years ago)

Author:

SergeyBiryukov

Message:

General: Replace all esc_url_raw() calls in core with sanitize_url().

This aims to improve performance by calling sanitize_url() directly, instead of the esc_url_raw() wrapper. As of WordPress 6.1, sanitize_url() is the recommended function for sanitizing a URL for database or redirect usage.

Follow-up to [11383], [13096], [51597], [53452].

Props benjgrolleau, peterwilsoncc, SergeyBiryukov.
Fixes #55852.

File:

• trunk/src/wp-admin/includes/class-custom-background.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-custom-background.php

@@ -527 +527 @@
                 update_post_meta( $id, '_wp_attachment_is_custom_background', get_option( 'stylesheet' ) );
 
-                set_theme_mod( 'background_image', esc_url_raw( $url ) );
+                set_theme_mod( 'background_image', sanitize_url( $url ) );
 
                 $thumbnail = wp_get_attachment_image_src( $id, 'thumbnail' );
-                set_theme_mod( 'background_image_thumb', esc_url_raw( $thumbnail[0] ) );
+                set_theme_mod( 'background_image_thumb', sanitize_url( $thumbnail[0] ) );
 
                 /** This action is documented in wp-admin/includes/class-custom-image-header.php */
@@ -619 +619 @@
                 $url       = wp_get_attachment_image_src( $attachment_id, $size );
                 $thumbnail = wp_get_attachment_image_src( $attachment_id, 'thumbnail' );
-                set_theme_mod( 'background_image', esc_url_raw( $url[0] ) );
-                set_theme_mod( 'background_image_thumb', esc_url_raw( $thumbnail[0] ) );
+                set_theme_mod( 'background_image', sanitize_url( $url[0] ) );
+                set_theme_mod( 'background_image_thumb', sanitize_url( $thumbnail[0] ) );
                 exit;
         }