Changeset 53477

Timestamp:

06/07/2022 12:01:09 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use more descriptive names for wp_rand() test methods.

This aims to clarify the intention of the tests.

Follow-up to [53473].

Props mlajo, costdev, acoulombe, azouamauriac, swissspidy, tobifjellner, peterwilsoncc, audrasjb, marekdedic, SergeyBiryukov.
See #55194.

File:

• trunk/tests/phpunit/tests/pluggable.php (modified) (6 diffs)

trunk/tests/phpunit/tests/pluggable.php

@@ -357 +357 @@
 
         /**
-         * Tests that wp_rand() returns zero.
+         * Tests that wp_rand() returns zero when `$min` and `$max` are zero.
          *
          * @ticket 55194
-         * @dataProvider data_wp_rand_should_return_zero
+         * @dataProvider data_wp_rand_should_return_zero_when_min_and_max_are_zero
          * @covers ::wp_rand
          *
@@ -366 +366 @@
          * @param mixed $max Upper limit for the generated number.
          */
-        public function test_wp_rand_should_return_zero( $min, $max ) {
+        public function test_wp_rand_should_return_zero_when_min_and_max_are_zero( $min, $max ) {
                 $this->assertSame( 0, wp_rand( $min, $max ) );
         }
@@ -375 +375 @@
          * @return array
          */
-        public function data_wp_rand_should_return_zero() {
+        public function data_wp_rand_should_return_zero_when_min_and_max_are_zero() {
                 return array(
                         'min and max as 0'      => array(
@@ -393 +393 @@
 
         /**
-         * Tests that wp_rand() returns a value between 1 and 99.
+         * Tests that wp_rand() returns a positive integer for both positive and negative input.
          *
          * @ticket 55194
-         * @dataProvider data_wp_rand_should_return_between_1_and_99
+         * @dataProvider data_wp_rand_should_return_a_positive_integer
          * @covers ::wp_rand
          *
@@ -402 +402 @@
          * @param int $max Upper limit for the generated number.
          */
-        public function test_wp_rand_should_return_between_1_and_99( $min, $max ) {
+        public function test_wp_rand_should_return_a_positive_integer( $min, $max ) {
                 $this->assertGreaterThan(
                         0,
@@ -421 +421 @@
          * @return array
          */
-        public function data_wp_rand_should_return_between_1_and_99() {
+        public function data_wp_rand_should_return_a_positive_integer() {
                 return array(
                         '1 and 99'       => array(