Changeset 53479

Timestamp:

06/08/2022 01:17:27 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Correct an assertion in wp_rand() tests.

The function returns non-negative integers, which includes zero.

Follow-up to [53473], [53477].

See #55194.

File:

• trunk/tests/phpunit/tests/pluggable/wpRand.php (modified) (2 diffs)

trunk/tests/phpunit/tests/pluggable/wpRand.php

@@ -8 +8 @@
 
         /**
-         * Tests that wp_rand() returns a positive integer for both positive and negative input.
+         * Tests that wp_rand() returns a non-negative integer for both positive and negative input.
          *
          * @ticket 55194
-         * @dataProvider data_wp_rand_should_return_a_positive_integer
+         * @dataProvider data_wp_rand_should_return_a_non_negative_integer
          *
          * @param int $min Lower limit for the generated number.
          * @param int $max Upper limit for the generated number.
          */
-        public function test_wp_rand_should_return_a_positive_integer( $min, $max ) {
-                $this->assertGreaterThan(
+        public function test_wp_rand_should_return_a_non_negative_integer( $min, $max ) {
+                $this->assertGreaterThanOrEqual(
                         0,
                         wp_rand( $min, $max ),
-                        'The value was not greater than 0'
+                        'The value was not greater than or equal 0'
                 );
 
@@ -35 +35 @@
          * @return array
          */
-        public function data_wp_rand_should_return_a_positive_integer() {
+        public function data_wp_rand_should_return_a_non_negative_integer() {
                 return array(
                         '1 and 99'       => array(