Changeset 53485

Timestamp:

06/10/2022 03:45:45 PM (2 years ago)

Author:

spacedmonkey

Message:

REST API: Improve post cache priming in WP_REST_Post_Search_Handler class.

In the WP_REST_Post_Search_Handler class, ensure that post, post meta and term caches are correctly primed when performing a search.

Props furi3r, spacedmonkey, TimothyBlynJacobs, audrasjb, peterwilsoncc.
Fixes #55674.

Location:

trunk

Files:

• src/wp-includes/rest-api/search/class-wp-rest-post-search-handler.php (modified) (2 diffs)
• tests/phpunit/tests/rest-api/rest-search-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/search/class-wp-rest-post-search-handler.php

@@ -59 +59 @@
 
         $query_args = array(
-            'post_type'           => $post_types,
-            'post_status'         => 'publish',
-            'paged'               => (int) $request['page'],
-            'posts_per_page'      => (int) $request['per_page'],
-            'ignore_sticky_posts' => true,
-            'fields'              => 'ids',
+            'post_type'              => $post_types,
+            'post_status'            => 'publish',
+            'paged'                  => (int) $request['page'],
+            'posts_per_page'         => (int) $request['per_page'],
+            'ignore_sticky_posts'    => true,
         );
 
@@ -84 +83 @@
 
         $query     = new WP_Query();
-        $found_ids = $query->query( $query_args );
+        $posts     = $query->query( $query_args );
+        // Querying the whole post object will warm the object cache, avoiding an extra query per result.
+        $found_ids = wp_list_pluck( $posts, 'ID' );
         $total     = $query->found_posts;
 

trunk/tests/phpunit/tests/rest-api/rest-search-controller.php

@@ -334 +334 @@
 
     /**
+     * @ticket 55674
+     */
+    public function test_get_items_search_prime_ids() {
+        $action = new MockAction();
+        add_filter( 'query', array( $action, 'filter' ), 10, 2 );
+
+        $query_args = array(
+            'per_page' => 100,
+            'search'   => 'foocontent',
+        );
+        $response   = $this->do_request_with_params( $query_args );
+        $this->assertSame( 200, $response->get_status(), 'Request Status Response is not 200.' );
+
+        $ids = wp_list_pluck( $response->get_data(), 'id' );
+        $this->assertSameSets( self::$my_content_post_ids, $ids, 'Query result posts ids do not match with expected ones.' );
+
+        $args               = $action->get_args();
+        $primed_query_found = false;
+        foreach ( $args as $arg ) {
+            // Primed query will use WHERE ID IN clause.
+            if ( str_contains( $arg[0], 'WHERE ID IN (' . implode( ',', $ids ) ) ) {
+                $primed_query_found = true;
+                break;
+            }
+        }
+
+        $this->assertTrue( $primed_query_found, 'Prime query was not executed.' );
+    }
+
+    /**
      * Test retrieving a single item isn't possible.
      */