Changeset 53485 for trunk/src/wp-includes/rest-api/search/class-wp-rest-post-search-handler.php

Timestamp:

06/10/2022 03:45:45 PM (3 years ago)

Author:

spacedmonkey

Message:

REST API: Improve post cache priming in WP_REST_Post_Search_Handler class.

In the WP_REST_Post_Search_Handler class, ensure that post, post meta and term caches are correctly primed when performing a search.

Props furi3r, spacedmonkey, TimothyBlynJacobs, audrasjb, peterwilsoncc.
Fixes #55674.

File:

• trunk/src/wp-includes/rest-api/search/class-wp-rest-post-search-handler.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/search/class-wp-rest-post-search-handler.php

@@ -59 +59 @@
 
         $query_args = array(
-            'post_type'           => $post_types,
-            'post_status'         => 'publish',
-            'paged'               => (int) $request['page'],
-            'posts_per_page'      => (int) $request['per_page'],
-            'ignore_sticky_posts' => true,
-            'fields'              => 'ids',
+            'post_type'              => $post_types,
+            'post_status'            => 'publish',
+            'paged'                  => (int) $request['page'],
+            'posts_per_page'         => (int) $request['per_page'],
+            'ignore_sticky_posts'    => true,
         );
 
@@ -84 +83 @@
 
         $query     = new WP_Query();
-        $found_ids = $query->query( $query_args );
+        $posts     = $query->query( $query_args );
+        // Querying the whole post object will warm the object cache, avoiding an extra query per result.
+        $found_ids = wp_list_pluck( $posts, 'ID' );
         $total     = $query->found_posts;