Changeset 53498 for trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

Timestamp:

06/14/2022 12:40:29 PM (3 years ago)

Author:

spacedmonkey

Message:

REST API: Avoid duplicated query in post collections.

Avoid duplicated query when retrieving empty posts collections by adding a check if the page is more than 1.

Props furi3r, gdetassigny, TimothyBlynJacobs, spacedmonkey.
Fixes #55677.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -1386 +1386 @@
         $this->assertCount( 0, $response->get_data() );
 
-        // FIXME Since this request returns zero posts, the query is executed twice.
-        $this->assertCount( 2, $this->posts_clauses );
+        $this->assertCount( 1, $this->posts_clauses );
         $this->posts_clauses = array_slice( $this->posts_clauses, 0, 1 );
 
@@ -1418 +1417 @@
         $this->assertCount( 0, $response->get_data() );
 
-        // FIXME Since this request returns zero posts, the query is executed twice.
-        $this->assertCount( 2, $this->posts_clauses );
+        $this->assertCount( 1, $this->posts_clauses );
         $this->posts_clauses = array_slice( $this->posts_clauses, 0, 1 );
 
@@ -1437 +1435 @@
         $this->assertCount( 0, $response->get_data() );
 
-        // FIXME Since this request returns zero posts, the query is executed twice.
-        $this->assertCount( 2, $this->posts_clauses );
+        $this->assertCount( 1, $this->posts_clauses );
         $this->posts_clauses = array_slice( $this->posts_clauses, 0, 1 );