Changeset 53499

Timestamp:

06/14/2022 01:08:39 PM (4 years ago)

Author:

spacedmonkey

Message:

REST API: Prime caches for featured images in post controller.

Ensure that featured image caches are primed for post collections in the post REST API controller, by calling the update_post_thumbnail_cache function.

Props Spacedmonkey, TimothyBlynJacobs, mitogh.
Fixes #55592.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -371 +371 @@
 
                 update_post_author_caches( $query_result );
+                if ( post_type_supports( $this->post_type, 'thumbnail' ) ) {
+                        update_post_thumbnail_cache( $posts_query );
+                }
 
                 foreach ( $query_result as $post ) {

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -1513 +1513 @@
 
                 $this->assertPostsWhere( " AND {posts}.ID NOT IN ($id3) AND {posts}.post_type = 'post' AND (({posts}.post_status = 'publish'))" );
+        }
+
+        /**
+         * @ticket 55592
+         * @covers WP_REST_Posts_Controller::get_items()
+         */
+        public function test_get_items_with_featured_media() {
+                $file           = DIR_TESTDATA . '/images/canola.jpg';
+                $attachment_ids = array();
+                $post_ids       = array();
+                for ( $i = 0; $i < 3; $i++ ) {
+                        $post_ids[ $i ]       = self::factory()->post->create( array( 'post_status' => 'publish' ) );
+                        $attachment_ids[ $i ] = self::factory()->attachment->create_object(
+                                $file,
+                                $post_ids[ $i ],
+                                array(
+                                        'post_mime_type' => 'image/jpeg',
+                                )
+                        );
+                        set_post_thumbnail( $post_ids[ $i ], $attachment_ids[ $i ] );
+                }
+
+                // Attachment creation warms thumbnail ids. Needs clean up for test.
+                wp_cache_delete_multiple( $attachment_ids, 'posts' );
+
+                $filter = new MockAction();
+                add_filter( 'update_post_metadata_cache', array( $filter, 'filter' ), 10, 2 );
+
+                $request = new WP_REST_Request( 'GET', '/wp/v2/posts' );
+                $request->set_param( 'include', $post_ids );
+                rest_get_server()->dispatch( $request );
+
+                $args = $filter->get_args();
+                $last = end( $args );
+                $this->assertIsArray( $last, 'The last value is not an array' );
+                $this->assertEqualSets( $attachment_ids, $last[1] );
         }