Changeset 53505

Timestamp:

06/15/2022 10:34:07 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Database: Don't translate the "WordPress database error" message in the error log.

When using multilingual websites, this string could end up with multiple different translations in the error log, making it less actionable.

Unlike errors displayed to the user, a general consensus for software is that errors in logs should always be in English. Since MySQL errors are also returned in English, this brings more consistency to the logs.

Follow-up to [6391], [8168], [19760].

Props malthert.
Fixes #53125.

File:

• trunk/src/wp-includes/wp-db.php (modified) (2 diffs)

trunk/src/wp-includes/wp-db.php

@@ -1569 +1569 @@
         }
 
-        wp_load_translations_early();
-
         $caller = $this->get_caller();
         if ( $caller ) {
-            /* translators: 1: Database error message, 2: SQL query, 3: Name of the calling function. */
-            $error_str = sprintf( __( 'WordPress database error %1$s for query %2$s made by %3$s' ), $str, $this->last_query, $caller );
+            // Not translated, as this will only appear in the error log.
+            $error_str = sprintf( 'WordPress database error %1$s for query %2$s made by %3$s', $str, $this->last_query, $caller );
         } else {
-            /* translators: 1: Database error message, 2: SQL query. */
-            $error_str = sprintf( __( 'WordPress database error %1$s for query %2$s' ), $str, $this->last_query );
+            $error_str = sprintf( 'WordPress database error %1$s for query %2$s', $str, $this->last_query );
         }
 
@@ -1586 +1583 @@
             return false;
         }
+
+        wp_load_translations_early();
 
         // If there is an error then take note of it.