Changeset 53506

Timestamp:

06/15/2022 10:41:32 AM (2 years ago)

Author:

spacedmonkey

Message:

REST API: Prime caches for post parents in post REST API controller.

Prime caches for all post parents in the post REST API controller using the _prime_post_caches function. Post parent objects are required as part of the check_read_permission method’s permission check in post REST API controller.

Props spacedmonkey, furi3r, peterwilsoncc, mitogh, madpixels.
Fixes #55593.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -7491 +7491 @@
 
 /**
+ * Prime post parent post caches.
+ *
+ * @since 6.1.0
+ *
+ * @param WP_Post[] $posts Array of Post objects.
+ */
+function update_post_parent_caches( $posts ) {
+    $parent_ids = wp_list_pluck( $posts, 'post_parent' );
+    $parent_ids = array_map( 'absint', $parent_ids );
+    $parent_ids = array_unique( array_filter( $parent_ids ) );
+    if ( ! empty( $parent_ids ) ) {
+        _prime_post_caches( $parent_ids, false );
+    }
+}
+
+/**
  * Updates metadata cache for a list of post IDs.
  *

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -370 +370 @@
         $posts = array();
 
+        update_post_parent_caches( $query_result );
         update_post_author_caches( $query_result );
         if ( post_type_supports( $this->post_type, 'thumbnail' ) ) {

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -1786 +1786 @@
 
         $this->assertSame( $formats, $data['schema']['properties']['format']['enum'] );
+    }
+
+    /**
+     * @ticket 55593
+     */
+    public function test_get_items_parent_ids_primed() {
+        $parent_id1 = self::$post_ids[0];
+        $parent_id2 = self::$post_ids[1];
+        $parent_ids = array( $parent_id2, $parent_id1 );
+
+        $this->factory->attachment->create_object(
+            DIR_TESTDATA . '/images/canola.jpg',
+            $parent_id1,
+            array(
+                'post_mime_type' => 'image/jpeg',
+                'post_excerpt'   => 'A sample caption 1',
+            )
+        );
+
+        $this->factory->attachment->create_object(
+            DIR_TESTDATA . '/images/canola.jpg',
+            $parent_id2,
+            array(
+                'post_mime_type' => 'image/jpeg',
+                'post_excerpt'   => 'A sample caption 2',
+            )
+        );
+
+        // Attachment creation warms parent ids. Needs clean up for test.
+        wp_cache_delete_multiple( $parent_ids, 'posts' );
+
+        $filter = new MockAction();
+        add_filter( 'update_post_metadata_cache', array( $filter, 'filter' ), 10, 2 );
+
+        $request = new WP_REST_Request( 'GET', '/wp/v2/media' );
+        rest_get_server()->dispatch( $request );
+
+        $args = $filter->get_args();
+        $last = end( $args );
+        $this->assertIsArray( $last, 'The last value is not an array' );
+        $this->assertEqualSets( $parent_ids, $last[1] );
     }