Changeset 53507

Timestamp:

06/15/2022 01:17:59 PM (4 years ago)

Author:

SergeyBiryukov

Message:

REST API: Some documentation and test improvements for update_post_parent_caches():

• Make the function description more specific, for consistency with update_post_author_caches().
• Add missing @covers tags for the unit test.

Follow-up to [53506].

See #55593.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (2 diffs)
• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (2 diffs)

trunk/src/wp-includes/post.php

@@ -7491 +7491 @@
 
 /**
- * Prime post parent post caches.
+ * Updates parent post caches for a list of post objects.
  *
  * @since 6.1.0
  *
- * @param WP_Post[] $posts Array of Post objects.
+ * @param WP_Post[] $posts Array of post objects.
  */
 function update_post_parent_caches( $posts ) {
@@ -7501 +7501 @@
         $parent_ids = array_map( 'absint', $parent_ids );
         $parent_ids = array_unique( array_filter( $parent_ids ) );
+
         if ( ! empty( $parent_ids ) ) {
                 _prime_post_caches( $parent_ids, false );

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -370 +370 @@
                 $posts = array();
 
+                update_post_author_caches( $query_result );
                 update_post_parent_caches( $query_result );
-                update_post_author_caches( $query_result );
+
                 if ( post_type_supports( $this->post_type, 'thumbnail' ) ) {
                         update_post_thumbnail_cache( $posts_query );

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -1517 +1517 @@
         /**
          * @ticket 55592
-         * @covers WP_REST_Posts_Controller::get_items()
+         * @covers WP_REST_Posts_Controller::get_items
          */
         public function test_get_items_with_featured_media() {
@@ -1790 +1790 @@
         /**
          * @ticket 55593
+         * @covers WP_REST_Posts_Controller::get_items
+         * @covers update_post_parent_caches
          */
         public function test_get_items_parent_ids_primed() {