Changeset 53510

Timestamp:

06/15/2022 02:42:58 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSameSets() in some newly introduced tests.

This ensures that not only the array values being compared are equal, but also that their type is the same.

Going forward, stricter type checking by using assertSameSets() or assertSameSetsWithIndex() should generally be preferred, to make the tests more reliable.

Follow-up to [48939], [51137], [51943], [53499], [53504], [53506], [53509].

See #55652.

Location:

trunk/tests/phpunit/tests

Files:

• post/nav-menu.php (modified) (2 diffs)
• rest-api/rest-posts-controller.php (modified) (2 diffs)
• rest-api/rest-users-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/post/nav-menu.php

@@ -231 +231 @@
         $args = $action->get_args();
         $last = end( $args );
-        $this->assertEqualSets( array( $post_id ), $last[1], '_prime_post_caches() was not executed.' );
+        $this->assertSameSets( array( $post_id ), $last[1], '_prime_post_caches() was not executed.' );
     }
 
@@ -263 +263 @@
         $args = $action->get_args();
         $last = end( $args );
-        $this->assertEqualSets( array( $term_id ), $last[1], '_prime_term_caches() was not executed.' );
+        $this->assertSameSets( array( $term_id ), $last[1], '_prime_term_caches() was not executed.' );
     }
 

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -1549 +1549 @@
         $last = end( $args );
         $this->assertIsArray( $last, 'The last value is not an array' );
-        $this->assertEqualSets( $attachment_ids, $last[1] );
+        $this->assertSameSets( $attachment_ids, $last[1] );
     }
 
@@ -1592 +1592 @@
         $last = end( $args );
         $this->assertIsArray( $last, 'The last value is not an array' );
-        $this->assertEqualSets( $parent_ids, $last[1] );
+        $this->assertSameSets( $parent_ids, $last[1] );
     }
 

trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -193 +193 @@
         $data     = $response->get_data();
         $keys     = array_keys( $data['endpoints'][0]['args'] );
-        $this->assertEqualSets(
+        $this->assertSameSets(
             array(
                 'context',