Changeset 53512

Timestamp:

06/15/2022 07:32:25 PM (4 years ago)

Author:

spacedmonkey

Message:

Tests: Re-enable failing REST API test for update_post_parent_caches().

Ensure that that attachment objects are not primed in cache so that test passes when object caching is enabled.

Follow-up to [53506].

Props SergeyBiryukov.
See #55593.

File:

• trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php (modified) (4 diffs)

trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php

@@ -1558 +1558 @@
          */
         public function test_get_items_primes_parent_post_caches() {
-                $parent_id1 = self::$post_ids[0];
-                $parent_id2 = self::$post_ids[1];
-                $parent_ids = array( $parent_id2, $parent_id1 );
-
-                $this->factory->attachment->create_object(
+                $parent_id1       = self::$post_ids[0];
+                $parent_id2       = self::$post_ids[1];
+                $parent_ids       = array( $parent_id1, $parent_id2 );
+                $attachment_ids   = array();
+                $attachment_ids[] = $this->factory->attachment->create_object(
                         DIR_TESTDATA . '/images/canola.jpg',
                         $parent_id1,
@@ -1571 +1571 @@
                 );
 
-                $this->factory->attachment->create_object(
+                $attachment_ids[] = $this->factory->attachment->create_object(
                         DIR_TESTDATA . '/images/canola.jpg',
                         $parent_id2,
@@ -1582 +1582 @@
                 // Attachment creation warms parent IDs. Needs clean up for test.
                 wp_cache_delete_multiple( $parent_ids, 'posts' );
+                wp_cache_delete_multiple( $attachment_ids, 'posts' );
 
                 $filter = new MockAction();
@@ -1592 +1593 @@
                 $last = end( $args );
                 $this->assertIsArray( $last, 'The last value is not an array' );
-                // TODO: Enable this once the test is updated to pass with persistent object cache.
-                // $this->assertSameSets( $parent_ids, $last[1] );
+                $this->assertSameSets( $parent_ids, $last[1] );
         }