Changeset 53532

Timestamp:

06/19/2022 05:26:52 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Consistently check that an image was loaded in image saving tests.

Don't unnecessarily load the image twice in test_inferred_mime_types_when_saving_an_image().

Follow-up to [1061/tests], [1151/tests], [1157/tests], [29834].

See #55652.

File:

• trunk/tests/phpunit/tests/image/functions.php (modified) (3 diffs)

trunk/tests/phpunit/tests/image/functions.php

@@ -258 +258 @@
         $loaded = $img->load();
 
+        $this->assertNotWPError( $loaded, 'Image failed to load - WP_Error returned' );
+
         if ( ! $img->supports_mime_type( $mime_type ) ) {
             $this->markTestSkipped(
@@ -333 +335 @@
         $loaded = $img->load();
 
+        $this->assertNotWPError( $loaded, 'Image failed to load - WP_Error returned' );
+
         // Save the file.
         $mime_type = 'image/gif';
@@ -376 +380 @@
         $loaded = $img->load();
 
-        $img = wp_get_image_editor( DIR_TESTDATA . '/images/canola.jpg' );
-        $this->assertNotWPError( $img );
+        $this->assertNotWPError( $loaded, 'Image failed to load - WP_Error returned' );
 
         if ( ! $img->supports_mime_type( $mime_type ) ) {