WordPress.org
Get WordPress

Make WordPress Core

Changeset 53533


Ignore:
Timestamp:
06/20/2022 12:48:35 PM (4 years ago)
Author:
SergeyBiryukov
Message:

Tests: Use consistent punctuation in failure messages in Tests_Image_Functions.

Follow-up to [53523], [53524], [53525], [53526], [53529], [53530], [53531].

See #55652.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/image/functions.php

    r53532 r53533  
    7575        $this->assertTrue(
    7676            file_is_valid_image( DIR_TESTDATA . '/images/' . $file ),
    77             "file_is_valid_image( '$file' ) should return true"
     77            "file_is_valid_image( '$file' ) should return true."
    7878        );
    7979    }
    … …  
    119119        $this->assertFalse(
    120120            file_is_valid_image( DIR_TESTDATA . '/images/' . $file ),
    121             "file_is_valid_image( '$file' ) should return false"
     121            "file_is_valid_image( '$file' ) should return false."
    122122        );
    123123    }
    … …  
    149149        $this->assertTrue(
    150150            file_is_displayable_image( DIR_TESTDATA . '/images/' . $file ),
    151             "file_is_displayable_image( '$file' ) should return true"
     151            "file_is_displayable_image( '$file' ) should return true."
    152152        );
    153153    }
    … …  
    191191        $this->assertFalse(
    192192            file_is_displayable_image( DIR_TESTDATA . '/images/' . $file ),
    193             "file_is_displayable_image( '$file' ) should return false"
     193            "file_is_displayable_image( '$file' ) should return false."
    194194        );
    195195    }
    … …  
    258258        $loaded = $img->load();
    259259
    260         $this->assertNotWPError( $loaded, 'Image failed to load - WP_Error returned' );
     260        $this->assertNotWPError( $loaded, 'Image failed to load - WP_Error returned.' );
    261261
    262262        if ( ! $img->supports_mime_type( $mime_type ) ) {
    263263            $this->markTestSkipped(
    264264                sprintf(
    265                     'The %s mime type is not supported by the %s engine',
     265                    'The %s mime type is not supported by the %s engine.',
    266266                    $mime_type,
    267267                    str_replace( 'WP_Image_Editor_', '', $class_name )
    … …  
    275275
    276276        // Make assertions.
    277         $this->assertNotEmpty( $ret, 'Image failed to save - "empty" response returned' );
    278         $this->assertNotWPError( $ret, 'Image failed to save - WP_Error returned' );
    279         $this->assertSame( $mime_type, $this->get_mime_type( $ret['path'] ), 'Mime type of the saved image does not match' );
     277        $this->assertNotEmpty( $ret, 'Image failed to save - "empty" response returned.' );
     278        $this->assertNotWPError( $ret, 'Image failed to save - WP_Error returned.' );
     279        $this->assertSame( $mime_type, $this->get_mime_type( $ret['path'] ), 'Mime type of the saved image does not match.' );
    280280
    281281        // Clean up.
    … …  
    335335        $loaded = $img->load();
    336336
    337         $this->assertNotWPError( $loaded, 'Image failed to load - WP_Error returned' );
     337        $this->assertNotWPError( $loaded, 'Image failed to load - WP_Error returned.' );
    338338
    339339        // Save the file.
    … …  
    343343
    344344        // Make assertions.
    345         $this->assertNotEmpty( $ret, 'Image failed to save - "empty" response returned' );
    346         $this->assertNotWPError( $ret, 'Image failed to save - WP_Error returned' );
    347         $this->assertSame( $mime_type, $this->get_mime_type( $ret['path'] ), 'Mime type of the saved image did not override file name' );
     345        $this->assertNotEmpty( $ret, 'Image failed to save - "empty" response returned.' );
     346        $this->assertNotWPError( $ret, 'Image failed to save - WP_Error returned.' );
     347        $this->assertSame( $mime_type, $this->get_mime_type( $ret['path'] ), 'Mime type of the saved image did not override file name.' );
    348348
    349349        // Clean up.
    … …  
    380380        $loaded = $img->load();
    381381
    382         $this->assertNotWPError( $loaded, 'Image failed to load - WP_Error returned' );
     382        $this->assertNotWPError( $loaded, 'Image failed to load - WP_Error returned.' );
    383383
    384384        if ( ! $img->supports_mime_type( $mime_type ) ) {
    385385            $this->markTestSkipped(
    386386                sprintf(
    387                     'The %s mime type is not supported by the %s engine',
     387                    'The %s mime type is not supported by the %s engine.',
    388388                    $mime_type,
    389389                    str_replace( 'WP_Image_Editor_', '', $class_name )
    … …  
    398398
    399399        // Make assertions.
    400         $this->assertNotEmpty( $ret, 'Image failed to save - "empty" response returned' );
    401         $this->assertNotWPError( $ret, 'Image failed to save - WP Error returned' );
    402         $this->assertSame( $mime_type, $this->get_mime_type( $ret['path'] ), 'Mime type of the saved image was not inferred correctly' );
     400        $this->assertNotEmpty( $ret, 'Image failed to save - "empty" response returned.' );
     401        $this->assertNotWPError( $ret, 'Image failed to save - WP Error returned.' );
     402        $this->assertSame( $mime_type, $this->get_mime_type( $ret['path'] ), 'Mime type of the saved image was not inferred correctly.' );
    403403
    404404        // Clean up.
Note: See TracChangeset for help on using the changeset viewer.