Changeset 53534 for trunk/.github/workflows/slack-notifications.yml

Timestamp:

06/20/2022 02:58:45 PM (2 years ago)

Author:

desrosj

Message:

Build/Test Tools: Adjust Slack notifications logic to account for expected non push events.

This adjusts the logic used to determine the outcome of the previous workflow run of the current one to account for schedule and workflow_dispatch events.

In the current state, only workflows triggered by push events are examined. This is causing failures when trying to post Slack notifications for the Test Coverage workflow, and inconsistent results for workflow_dispatch events when testing older branches on a schedule.

Follow up to [53466] and [53468].
See #55652.

File:

• trunk/.github/workflows/slack-notifications.yml (modified) (2 diffs)

trunk/.github/workflows/slack-notifications.yml

@@ -113 +113 @@
             }
 
+            const expected_events = new Array( 'push', 'schedule', 'workflow_dispatch' );
+
             // Find the workflow run for the commit that immediately preceded this one.
             for ( let i = 0; i < previous_runs.data.workflow_runs.length; i++ ) {
@@ -121 +123 @@
 
                   // Protects against a false notification when contributors use the trunk branch as the pull request head_ref.
-                  if ( previous_runs.data.workflow_runs[ next_index ].event !== "push" ) {
+                  if ( expected_events.indexOf( previous_runs.data.workflow_runs[ next_index ].event ) == -1 ) {
                     continue;
                   }