Changeset 53538

Timestamp:

06/20/2022 09:35:03 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Improve Tests_Image_Functions::test_wp_crop_image*() tests.

Includes:

• Adding @covers annotations.
• Adding a failure message to each assertion when multiple assertions are used in the test.

Follow-up to [1126/tests], [53495], [53497], [53521], [53523], [53524], [53525], [53526], [53529], [53530], [53531], [53537].

Props jrf.
See #55652.

File:

• trunk/tests/phpunit/tests/image/functions.php (modified) (7 diffs)

trunk/tests/phpunit/tests/image/functions.php

@@ -485 +485 @@
     /**
      * @ticket 55403
+     * @covers ::wp_crop_image
      */
     public function test_wp_crop_image_with_filtered_extension() {
@@ -509 +510 @@
 
     /**
+     * @covers ::wp_crop_image
      * @requires function imagejpeg
      */
@@ -521 +523 @@
             100
         );
-        $this->assertNotWPError( $file );
-        $this->assertFileExists( $file );
+        $this->assertNotWPError( $file, 'Cropping the image resulted in a WP_Error.' );
+        $this->assertFileExists( $file, "The file $file does not exist." );
+
         $image = wp_get_image_editor( $file );
         $size  = $image->get_size();
-        $this->assertSame( 100, $size['height'] );
-        $this->assertSame( 100, $size['width'] );
+
+        $this->assertSame( 100, $size['height'], 'Cropped image height does not match expectation.' );
+        $this->assertSame( 100, $size['width'], 'Cropped image width does not match expectation.' );
 
         unlink( $file );
@@ -532 +536 @@
 
     /**
+     * @covers ::wp_crop_image
      * @requires function imagejpeg
      * @requires extension openssl
@@ -552 +557 @@
         }
 
-        $this->assertNotWPError( $file );
-        $this->assertFileExists( $file );
+        $this->assertNotWPError( $file, 'Cropping the image resulted in a WP_Error.' );
+        $this->assertFileExists( $file, "The file $file does not exist." );
+
         $image = wp_get_image_editor( $file );
         $size  = $image->get_size();
-        $this->assertSame( 100, $size['height'] );
-        $this->assertSame( 100, $size['width'] );
+
+        $this->assertSame( 100, $size['height'], 'Cropped image height does not match expectation.' );
+        $this->assertSame( 100, $size['width'], 'Cropped image width does not match expectation.' );
 
         unlink( $file );
     }
 
-    public function test_wp_crop_image_file_not_exist() {
+    /**
+     * @covers ::wp_crop_image
+     */
+    public function test_wp_crop_image_file_not_exists() {
         $file = wp_crop_image(
             DIR_TESTDATA . '/images/canoladoesnotexist.jpg',
@@ -576 +586 @@
 
     /**
+     * @covers ::wp_crop_image
      * @requires extension openssl
      */
-    public function test_wp_crop_image_url_not_exist() {
+    public function test_wp_crop_image_url_not_exists() {
         $file = wp_crop_image(
             'https://asdftestblog1.files.wordpress.com/2008/04/canoladoesnotexist.jpg',
@@ -593 +604 @@
     /**
      * @ticket 23325
+     * @covers ::wp_crop_image
      */
     public function test_wp_crop_image_error_on_saving() {