Changeset 53555

Timestamp:

06/22/2022 02:53:49 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Use the integer portion of an item position in add_submenu_page().

This fixes an Implicit conversion from float to int loses precision PHP 8.1 deprecation notice when adding a new admin menu item with a float value passed as the $position parameter.

This change is covered by existing unit tests and addresses 8 errors when running the test suite on PHP 8.1.

References:

• ​PHP 8.1: Implicit incompatible float to int conversion is deprecated
• ​PHP RFC: Deprecate implicit non-integer-compatible float to int conversions

Follow-up to [52569], [53104].

Props jrf.
See #55656, #54798.

File:

• trunk/src/wp-admin/includes/plugin.php (modified) (1 diff)

trunk/src/wp-admin/includes/plugin.php

@@ -1455 +1455 @@
             array_unshift( $submenu[ $parent_slug ], $new_sub_menu );
         } else {
+            $position = absint( $position );
             // Grab all of the items before the insertion point.
             $before_items = array_slice( $submenu[ $parent_slug ], 0, $position, true );