Changeset 53557 for trunk/tests/phpunit/tests/attachment/slashes.php

Timestamp:

06/23/2022 02:24:08 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove dynamic properties in Tests_*_Slashes.

Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

In this particular case, the test classes contain a set_up() method that sets a group of properties, which are used by the tests, but the values of these properties are never changed by the tests.

In other words, setting these properties in the set_up() is an unnecessary overhead and the properties should be changed to class constants.

Follow-up to [1041/tests], [1071/tests].

Props jrf.
See #56033.

File:

• trunk/tests/phpunit/tests/attachment/slashes.php (modified) (5 diffs)

trunk/tests/phpunit/tests/attachment/slashes.php

@@ -7 +7 @@
  */
 class Tests_Attachment_Slashes extends WP_UnitTestCase {
+
+    /*
+     * It is important to test with both even and odd numbered slashes,
+     * as KSES does a strip-then-add slashes in some of its function calls.
+     */
+
+    const SLASH_1 = 'String with 1 slash \\';
+    const SLASH_2 = 'String with 2 slashes \\\\';
+    const SLASH_3 = 'String with 3 slashes \\\\\\';
+    const SLASH_4 = 'String with 4 slashes \\\\\\\\';
+    const SLASH_5 = 'String with 5 slashes \\\\\\\\\\';
+    const SLASH_6 = 'String with 6 slashes \\\\\\\\\\\\';
+    const SLASH_7 = 'String with 7 slashes \\\\\\\\\\\\\\';
+
     protected static $author_id;
 
@@ -17 +31 @@
 
         wp_set_current_user( self::$author_id );
-
-        // It is important to test with both even and odd numbered slashes,
-        // as KSES does a strip-then-add slashes in some of its function calls.
-        $this->slash_1 = 'String with 1 slash \\';
-        $this->slash_2 = 'String with 2 slashes \\\\';
-        $this->slash_3 = 'String with 3 slashes \\\\\\';
-        $this->slash_4 = 'String with 4 slashes \\\\\\\\';
-        $this->slash_5 = 'String with 5 slashes \\\\\\\\\\';
-        $this->slash_6 = 'String with 6 slashes \\\\\\\\\\\\';
-        $this->slash_7 = 'String with 7 slashes \\\\\\\\\\\\\\';
     }
 
@@ -36 +40 @@
             array(
                 'post_status'           => 'publish',
-                'post_title'            => $this->slash_1,
-                'post_content_filtered' => $this->slash_3,
-                'post_excerpt'          => $this->slash_5,
+                'post_title'            => self::SLASH_1,
+                'post_content_filtered' => self::SLASH_3,
+                'post_excerpt'          => self::SLASH_5,
                 'post_type'             => 'post',
             )
@@ -44 +48 @@
         $post    = get_post( $post_id );
 
-        $this->assertSame( wp_unslash( $this->slash_1 ), $post->post_title );
-        $this->assertSame( wp_unslash( $this->slash_3 ), $post->post_content_filtered );
-        $this->assertSame( wp_unslash( $this->slash_5 ), $post->post_excerpt );
+        $this->assertSame( wp_unslash( self::SLASH_1 ), $post->post_title );
+        $this->assertSame( wp_unslash( self::SLASH_3 ), $post->post_content_filtered );
+        $this->assertSame( wp_unslash( self::SLASH_5 ), $post->post_excerpt );
 
         $post_id = wp_insert_attachment(
             array(
                 'post_status'           => 'publish',
-                'post_title'            => $this->slash_2,
-                'post_content_filtered' => $this->slash_4,
-                'post_excerpt'          => $this->slash_6,
+                'post_title'            => self::SLASH_2,
+                'post_content_filtered' => self::SLASH_4,
+                'post_excerpt'          => self::SLASH_6,
                 'post_type'             => 'post',
             )
@@ -59 +63 @@
         $post    = get_post( $post_id );
 
-        $this->assertSame( wp_unslash( $this->slash_2 ), $post->post_title );
-        $this->assertSame( wp_unslash( $this->slash_4 ), $post->post_content_filtered );
-        $this->assertSame( wp_unslash( $this->slash_6 ), $post->post_excerpt );
+        $this->assertSame( wp_unslash( self::SLASH_2 ), $post->post_title );
+        $this->assertSame( wp_unslash( self::SLASH_4 ), $post->post_content_filtered );
+        $this->assertSame( wp_unslash( self::SLASH_6 ), $post->post_excerpt );
     }