Changeset 53572

Timestamp:

06/24/2022 02:41:11 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: Give the tests for adding empty post meta values more consistent names.

One of these was previously renamed to mention update_metadata_by_mid().

While update_metadata_by_mid() is indeed called in wp_ajax_add_meta() to update an existing meta value, the functionality change that the test intended to verify was in the latter function.

Follow-up to [44153], [53561].

See #55652.

Location:

trunk/tests/phpunit/tests

Files:

• admin/includesPost.php (modified) (1 diff)
• ajax/AddMeta.php (modified) (2 diffs)

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -828 +828 @@
     /**
      * @ticket 43559
-     */
-    public function test_post_add_meta_empty_is_allowed() {
+     *
+     * @covers ::add_meta
+     */
+    public function test_add_meta_allows_empty_values() {
         $p = self::factory()->post->create();
 

trunk/tests/phpunit/tests/ajax/AddMeta.php

@@ -15 +15 @@
      * @ticket 43559
      *
+     * @covers ::wp_ajax_add_meta
      * @covers ::add_post_meta
-     * @covers ::wp_ajax_add_meta
      */
-    public function test_post_add_meta_empty_is_allowed_ajax() {
+    public function test_wp_ajax_add_meta_allows_empty_values_on_adding() {
         $post = self::factory()->post->create();
 
@@ -44 +44 @@
      * @ticket 43559
      *
+     * @covers ::wp_ajax_add_meta
      * @covers ::update_metadata_by_mid
-     * @covers ::wp_ajax_add_meta
      */
-    public function test_update_metadata_by_mid_allows_empty_values_ajax() {
+    public function test_wp_ajax_add_meta_allows_empty_values_on_updating() {
         $post = self::factory()->post->create();