Changeset 53578

Timestamp:

06/26/2022 12:35:28 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Add a conditional to facilitate testing of the Rollbacks feature project.

The ​Rollback Update Failure feature project creates a temporary backup of plugins and themes before updating. This aims to make the update process more reliable and ensure that if a plugin or theme update fails, the previous version can be safely restored.

If the ​Rollback Update Failure plugin is installed, WP_Upgrader::install_package() will use the move_dir() function from there for better performance. Instead of copying a directory from one location to another, it uses the rename() PHP function to speed up the process, which is instrumental in creating a temporary backup without a delay. If the renaming failed, it falls back to copy_dir() WP function.

This conditional aims to facilitate broader testing of the feature. It is temporary, until the plugin is merged into core.

Props afragen, pbiron, costdev, davidbaumwald, audrasjb, jrf, SergeyBiryukov.
Fixes #56057. See #51857, #54166.

File:

• trunk/src/wp-admin/includes/class-wp-upgrader.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-upgrader.php

@@ -594 +594 @@
 
         // Copy new version of item into place.
-        $result = copy_dir( $source, $remote_destination );
+        if ( class_exists( 'Rollback_Update_Failure\WP_Upgrader' )
+            && function_exists( '\Rollback_Update_Failure\move_dir' )
+        ) {
+            /*
+             * If the {@link https://wordpress.org/plugins/rollback-update-failure/ Rollback Update Failure}
+             * feature plugin is installed, use the move_dir() function from there for better performance.
+             * Instead of copying a directory from one location to another, it uses the rename() PHP function
+             * to speed up the process. If the renaming failed, it falls back to copy_dir().
+             *
+             * This condition aims to facilitate broader testing of the Rollbacks (temp backups) feature project.
+             * It is temporary, until the plugin is merged into core.
+             */
+            $result = \Rollback_Update_Failure\move_dir( $source, $remote_destination );
+        } else {
+            $result = copy_dir( $source, $remote_destination );
+        }
+
         if ( is_wp_error( $result ) ) {
             if ( $args['clear_working'] ) {