Make WordPress Core

Changeset 53599 for branches/5.6


Ignore:
Timestamp:
06/30/2022 04:35:15 PM (2 years ago)
Author:
desrosj
Message:

Build/Test Tools: Use the Slack notifications workflow as a reusable one.

This backports several changesets that are required to remove the reliance on the workflow_run event for posting Slack notifications.

The Slack notification workflow will now be called as a reusable one, which has several benefits (see [53591]).

Several other minor GitHub Actions related updates are also being backported in this commit to maintain tooling consistency across branches that still receive security updates as a courtesy when necessary.

Merges [50446], [50473], [50704], [50796], [50930], [51341], [51355], [51498], [51511], [51535], [51924], [51925], [51937], [52002], [52130], [52183], [52233], [53112], [53581], [53582], [53592] to the 5.6 branch.
See #56095.

Location:
branches/5.6
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • branches/5.6

  • branches/5.6/.github/workflows/coding-standards.yml

    r50602 r53599  
    66  push:
    77    branches:
    8       - master
    98      - trunk
    109      - '3.[89]'
     
    1514  pull_request:
    1615    branches:
    17       - master
    1816      - trunk
    1917      - '3.[89]'
     
    3533  workflow_dispatch:
    3634
     35# Cancels all previous workflow runs for pull requests that have not completed.
     36concurrency:
     37  # The concurrency group contains the workflow name and the branch name for pull requests
     38  # or the commit hash for any other events.
     39  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     40  cancel-in-progress: true
     41
    3742jobs:
    3843  # Runs PHP coding standards checks.
     
    4954  # - Runs PHPCS on the full codebase with warnings suppressed.
    5055  # - Runs PHPCS on the `tests` directory without warnings suppressed.
    51   # - todo: Configure Slack notifications for failing scans.
    5256  phpcs:
    5357    name: PHP coding standards
    5458    runs-on: ubuntu-latest
     59    timeout-minutes: 20
    5560    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    5661
    5762    steps:
    5863      - name: Checkout repository
    59         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     64        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    6065
    6166      - name: Set up PHP
    62         uses: shivammathur/setup-php@afefcaf556d98dc7896cca380e181decb609ca44 # v2.10.0
     67        uses: shivammathur/setup-php@3eda58347216592f618bb1dff277810b6698e4ca # v2.19.1
    6368        with:
    6469          php-version: '7.4'
     
    7277
    7378      - name: Install Composer dependencies
    74         uses: ramsey/composer-install@92a7904348d4ad30236f3611e33b7f0c6f9edd70 # v1.1.0
     79        uses: ramsey/composer-install@f680dac46551dffb2234a240d65ae806c2999dd6 # v2.1.0
    7580        with:
    7681          composer-options: "--no-progress --no-ansi --no-interaction"
     
    9499  # Performs the following steps:
    95100  # - Checks out the repository.
    96   # - Logs debug information about the runner container.
    97   # - Installs NodeJS 14.
    98   # - Sets up caching for NPM.
     101  # - Logs debug information about the GitHub Action runner.
     102  # - Installs NodeJS.
    99103  # - Logs updated debug information.
    100   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     104  # _ Installs NPM dependencies.
    101105  # - Run the WordPress JSHint checks.
    102   # - todo: Configure Slack notifications for failing tests.
    103106  jshint:
    104107    name: JavaScript coding standards
    105108    runs-on: ubuntu-latest
     109    timeout-minutes: 20
    106110    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    107111    env:
     
    110114    steps:
    111115      - name: Checkout repository
    112         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     116        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    113117
    114118      - name: Log debug information
     
    120124
    121125      - name: Install NodeJS
    122         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     126        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    123127        with:
    124           node-version: 14
    125 
    126       - name: Cache NodeJS modules
    127         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    128         env:
    129           cache-name: cache-node-modules
    130         with:
    131           # npm cache files are stored in `~/.npm` on Linux/macOS
    132           path: ~/.npm
    133           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     128          node-version-file: '.nvmrc'
     129          cache: npm
    134130
    135131      - name: Log debug information
     
    143139      - name: Run JSHint
    144140        run: npm run grunt jshint
     141
     142  slack-notifications:
     143    name: Slack Notifications
     144    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     145    needs: [ phpcs, jshint ]
     146    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     147    with:
     148      calling_status: ${{ needs.phpcs.result == 'success' && needs.jshint.result == 'success' && 'success' || ( needs.phpcs.result == 'cancelled' || needs.jshint.result == 'cancelled' ) && 'cancelled' || 'failure' }}
     149    secrets:
     150      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     151      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     152      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     153      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
  • branches/5.6/.github/workflows/javascript-tests.yml

    r50602 r53599  
    55  push:
    66    branches:
    7       - master
    87      - trunk
    98      - '3.[89]'
     
    1413  pull_request:
    1514    branches:
    16       - master
    1715      - trunk
    1816      - '3.[89]'
     
    3331  workflow_dispatch:
    3432
     33# Cancels all previous workflow runs for pull requests that have not completed.
     34concurrency:
     35  # The concurrency group contains the workflow name and the branch name for pull requests
     36  # or the commit hash for any other events.
     37  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     38  cancel-in-progress: true
     39
    3540jobs:
    3641  # Runs the QUnit tests for WordPress.
    3742  #
    3843  # Performs the following steps:
    39   # - Cancels all previous workflow runs for pull requests that have not completed.
    4044  # - Checks out the repository.
    41   # - Logs debug information about the runner container.
    42   # - Installs NodeJS 14.
    43   # - Sets up caching for NPM.
     45  # - Logs debug information about the GitHub Action runner.
     46  # - Installs NodeJS.
    4447  # - Logs updated debug information.
    45   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     48  # _ Installs NPM dependencies.
    4649  # - Run the WordPress QUnit tests.
    47   # - todo: Configure Slack notifications for failing tests.
    4850  test-js:
    4951    name: QUnit Tests
    5052    runs-on: ubuntu-latest
     53    timeout-minutes: 20
    5154    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    5255
    5356    steps:
    54       - name: Cancel previous runs of this workflow (pull requests only)
    55         if: ${{ github.event_name == 'pull_request' }}
    56         uses: styfle/cancel-workflow-action@3d86a7cc43670094ac248017207be0295edbc31d # v0.8.0
    57 
    5857      - name: Checkout repository
    59         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     58        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    6059
    6160      - name: Log debug information
     
    6766
    6867      - name: Install NodeJS
    69         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     68        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    7069        with:
    71           node-version: 14
    72 
    73       - name: Cache NodeJS modules
    74         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    75         env:
    76           cache-name: cache-node-modules
    77         with:
    78           # npm cache files are stored in `~/.npm` on Linux/macOS
    79           path: ~/.npm
    80           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     70          node-version-file: '.nvmrc'
     71          cache: npm
    8172
    8273      - name: Log debug information
     
    9081      - name: Run QUnit tests
    9182        run: npm run grunt qunit:compiled
     83
     84  slack-notifications:
     85    name: Slack Notifications
     86    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     87    needs: [ test-js ]
     88    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     89    with:
     90      calling_status: ${{ needs.test-js.result == 'success' && 'success' || needs.test-js.result == 'cancelled' && 'cancelled' || 'failure' }}
     91    secrets:
     92      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     93      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     94      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     95      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
  • branches/5.6/.github/workflows/php-compatibility.yml

    r50602 r53599  
    55  push:
    66    branches:
    7       - master
    87      - trunk
    98      - '5.[5-9]'
     
    1413  pull_request:
    1514    branches:
    16       - master
    1715      - trunk
    1816      - '5.[5-9]'
     
    2927  workflow_dispatch:
    3028
     29# Cancels all previous workflow runs for pull requests that have not completed.
     30concurrency:
     31  # The concurrency group contains the workflow name and the branch name for pull requests
     32  # or the commit hash for any other events.
     33  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     34  cancel-in-progress: true
     35
    3136jobs:
    3237
     
    3843  # - Checks out the repository.
    3944  # - Sets up PHP.
    40   # - Logs debug information about the runner container.
     45  # - Logs debug information about the GitHub Action runner.
    4146  # - Installs Composer dependencies (use cache if possible).
    4247  # - Make Composer packages available globally.
    4348  # - Logs PHP_CodeSniffer debug information.
    4449  # - Runs the PHP compatibility tests.
    45   # - todo: Configure Slack notifications for failing scans.
    4650  php-comatibility:
    4751    name: Check PHP compatibility
    4852    runs-on: ubuntu-latest
     53    timeout-minutes: 20
    4954    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    5055
    5156    steps:
    5257      - name: Checkout repository
    53         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     58        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    5459
    5560      - name: Set up PHP
    56         uses: shivammathur/setup-php@afefcaf556d98dc7896cca380e181decb609ca44 # v2.10.0
     61        uses: shivammathur/setup-php@3eda58347216592f618bb1dff277810b6698e4ca # v2.19.1
    5762        with:
    5863          php-version: '7.4'
     
    6671
    6772      - name: Install Composer dependencies
    68         uses: ramsey/composer-install@92a7904348d4ad30236f3611e33b7f0c6f9edd70 # v1.1.0
     73        uses: ramsey/composer-install@f680dac46551dffb2234a240d65ae806c2999dd6 # v2.1.0
    6974        with:
    7075          composer-options: "--no-progress --no-ansi --no-interaction"
     
    7883      - name: Run PHP compatibility tests
    7984        run: phpcs --standard=phpcompat.xml.dist -q --report=checkstyle | cs2pr
     85
     86  slack-notifications:
     87    name: Slack Notifications
     88    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     89    needs: [ php-comatibility ]
     90    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     91    with:
     92      calling_status: ${{ needs.php-compatibility.result == 'success' && 'success' || needs.php-compatibility.result == 'cancelled' && 'cancelled' || 'failure' }}
     93    secrets:
     94      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     95      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     96      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     97      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
  • branches/5.6/.github/workflows/phpunit-tests.yml

    r51936 r53599  
    44  push:
    55    branches:
    6       - master
    76      - trunk
    87      - '3.[7-9]'
     
    1312  pull_request:
    1413    branches:
    15       - master
    1614      - trunk
    1715      - '3.[7-9]'
     
    2220    - cron: '0 0 * * 0'
    2321
     22# Cancels all previous workflow runs for pull requests that have not completed.
     23concurrency:
     24  # The concurrency group contains the workflow name and the branch name for pull requests
     25  # or the commit hash for any other events.
     26  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     27  cancel-in-progress: true
     28
    2429env:
    2530  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
     
    3035
    3136jobs:
    32   # Sets up the workflow for testing.
    33   #
    34   # Performs the following steps:
    35   # - Cancels all previous workflow runs for pull requests that have not completed.
    36   setup-workflow:
    37     name: Setup Workflow
    38     runs-on: ubuntu-latest
    39     if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    40 
    41     steps:
    42       - name: Cancel previous runs of this workflow (pull requests only)
    43         if: ${{ github.event_name == 'pull_request' }}
    44         uses: styfle/cancel-workflow-action@3d86a7cc43670094ac248017207be0295edbc31d # v0.8.0
    45 
    4637  # Runs the PHPUnit tests for WordPress.
    4738  #
    4839  # Performs the following steps:
    49   # - Set environment variables.
     40  # - Sets environment variables.
    5041  # - Sets up the environment variables needed for testing with memcached (if desired).
    51   # - Installs NodeJS 14.
    52   # - Sets up caching for NPM.
     42  # - Installs NodeJS.
    5343  # - Installs NPM dependencies
    5444  # - Configures caching for Composer.
    55   # - Installs Composer dependencies (if desired).
    56   # - Logs Docker debug information (about both the Docker installation within the runner).
     45  # - Installs Composer dependencies.
     46  # - Logs Docker debug information (about the Docker installation within the runner).
    5747  # - Starts the WordPress Docker container.
    58   # - Starts the memcached server after the Docker network has been created (if desired).
    59   # - Logs WordPress Docker container debug information.
    60   # - Logs debug general information.
     48  # - Starts the Memcached server after the Docker network has been created (if desired).
     49  # - Logs general debug information about the runner.
    6150  # - Logs the running Docker containers.
     51  # - Logs debug information from inside the WordPress Docker container.
    6252  # - Logs debug information about what's installed within the WordPress Docker containers.
    6353  # - Install WordPress within the Docker container.
     
    6656  # - Reconnect the directory to the Git repository.
    6757  # - Submit the test results to the WordPress.org host test results.
    68   # - todo: Configure Slack notifications for failing tests.
    6958  test-php:
    70     name: ${{ matrix.php }}${{ matrix.multisite && ' multisite' || '' }}${{ matrix.split_slow && ' slow tests' || '' }} ${{ matrix.memcached && ' with memcached' || '' }} on ${{ matrix.os }}
     59    name: ${{ matrix.php }}${{ matrix.multisite && ' multisite' || '' }}${{ matrix.split_slow && ' slow tests' || '' }}${{ matrix.memcached && ' with memcached' || '' }} on ${{ matrix.os }}
    7160    runs-on: ${{ matrix.os }}
     61    timeout-minutes: 20
    7262    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    7363    strategy:
     
    118108
    119109      - name: Checkout repository
    120         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     110        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    121111
    122112      - name: Install NodeJS
    123         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     113        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    124114        with:
    125           node-version: 14
    126 
    127       - name: Use cached Node modules
    128         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    129         env:
    130           cache-name: cache-node-modules
    131         with:
    132           # npm cache files are stored in `~/.npm` on Linux/macOS
    133           path: ~/.npm
    134           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     115          node-version-file: '.nvmrc'
     116          cache: npm
    135117
    136118      - name: Install Dependencies
     
    142124
    143125      - name: Cache Composer dependencies
    144         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
     126        uses: actions/cache@c3f1317a9e7b1ef106c153ac8c0f00fed3ddbc0d # v3.0.4
    145127        env:
    146128          cache-name: cache-composer-dependencies
     
    241223
    242224      - name: Checkout the WordPress Test Reporter
    243         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/master' && matrix.report }}
    244         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     225        if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
     226        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    245227        with:
    246228          repository: 'WordPress/phpunit-test-runner'
     
    248230
    249231      - name: Submit test results to the WordPress.org host test results
    250         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/master' && matrix.report }}
     232        if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
    251233        env:
    252234          WPT_REPORT_API_KEY: "${{ secrets.WPT_REPORT_API_KEY }}"
    253235        run: docker-compose run --rm -e WPT_REPORT_API_KEY -e WPT_PREPARE_DIR=/var/www -e WPT_TEST_DIR=/var/www php php test-runner/report.php
     236
     237  slack-notifications:
     238    name: Slack Notifications
     239    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     240    needs: [ test-php ]
     241    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     242    with:
     243      calling_status: ${{ needs.test-php.result == 'success' && 'success' || needs.test-php.result == 'cancelled' && 'cancelled' || 'failure' }}
     244    secrets:
     245      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     246      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     247      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     248      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
  • branches/5.6/.github/workflows/test-npm.yml

    r50602 r53599  
    44  push:
    55    branches:
    6       - master
    76      - trunk
    87      - '3.[7-9]'
     
    109  pull_request:
    1110    branches:
    12       - master
    1311      - trunk
    1412      - '3.[7-9]'
     
    2624  workflow_dispatch:
    2725
     26# Cancels all previous workflow runs for pull requests that have not completed.
     27concurrency:
     28  # The concurrency group contains the workflow name and the branch name for pull requests
     29  # or the commit hash for any other events.
     30  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     31  cancel-in-progress: true
     32
    2833env:
    2934  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
    3035
    3136jobs:
    32   # Prepares the workflow.
    33   #
    34   # Performs the following steps:
    35   # - Cancels all previous workflow runs for pull requests that have not completed.
    36   prepare-workflow:
    37     name: Prepare the workflow
    38     runs-on: ubuntu-latest
    39     if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    40 
    41     steps:
    42       - name: Cancel previous runs of this workflow (pull requests only)
    43         if: ${{ github.event_name == 'pull_request' }}
    44         uses: styfle/cancel-workflow-action@3d86a7cc43670094ac248017207be0295edbc31d # v0.8.0
    45 
    4637  # Verifies that installing NPM dependencies and building WordPress works as expected.
    4738  #
    4839  # Performs the following steps:
    4940  # - Checks out the repository.
    50   # - Logs debug information about the runner container.
    51   # - Installs NodeJS 14.
    52   # - Sets up caching for NPM.
    53   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     41  # - Logs debug information about the GitHub Action runner.
     42  # - Installs NodeJS.
     43  # _ Installs NPM dependencies.
    5444  # - Builds WordPress to run from the `build` directory.
    5545  # - Cleans up after building WordPress to the `build` directory.
     
    5949    name: Test NPM on ${{ matrix.os }}
    6050    runs-on: ${{ matrix.os }}
     51    timeout-minutes: 20
    6152    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    62     needs: prepare-workflow
    6353    strategy:
    6454      fail-fast: false
     
    6858    steps:
    6959      - name: Checkout repository
    70         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     60        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    7161
    7262      - name: Log debug information
     
    7969
    8070      - name: Install NodeJS
    81         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     71        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    8272        with:
    83           node-version: 14
    84 
    85       - name: Cache NodeJS modules (Ubuntu & MacOS)
    86         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    87         if: ${{ matrix.os != 'windows-latest' }}
    88         with:
    89           path: ~/.npm
    90           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
    91 
    92       - name: Get NPM cache directory (Windows only)
    93         if: ${{ matrix.os == 'windows-latest' }}
    94         id: npm-cache
    95         run: echo "::set-output name=dir::$(npm config get cache)"
    96 
    97       - name: Cache NodeJS modules (Windows only)
    98         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    99         if: ${{ matrix.os == 'windows-latest' }}
    100         with:
    101           path: ${{ steps.npm-cache.outputs.dir }}
    102           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     73          node-version-file: '.nvmrc'
     74          cache: npm
    10375
    10476      - name: Install Dependencies
     
    11587
    11688      - name: Clean after building in /src
    117         run: npm run grunt clean --dev
     89        run: npm run grunt clean -- --dev
    11890
    11991  # Verifies that installing NPM dependencies and building WordPress works as expected on MacOS.
    12092  #
    121   # This is a separate job in order to that more strict conditions can be used.
     93  # This is separate from the job above in order to use stricter conditions about when to run.
     94  # This avoids unintentionally consuming excessive minutes, as MacOS jobs consume minutes at a 10x rate.
    12295  #
    12396  # Performs the following steps:
    12497  # - Checks out the repository.
    125   # - Logs debug information about the runner container.
    126   # - Installs NodeJS 14.
    127   # - Sets up caching for NPM.
    128   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     98  # - Logs debug information about the GitHub Action runner.
     99  # - Installs NodeJS.
     100  # _ Installs NPM dependencies.
    129101  # - Builds WordPress to run from the `build` directory.
    130102  # - Cleans up after building WordPress to the `build` directory.
     
    134106    name: Test NPM on MacOS
    135107    runs-on: macos-latest
     108    timeout-minutes: 20
    136109    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
    137     needs: prepare-workflow
    138110    steps:
    139111      - name: Checkout repository
    140         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     112        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    141113
    142114      - name: Log debug information
     
    149121
    150122      - name: Install NodeJS
    151         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     123        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    152124        with:
    153           node-version: 14
    154 
    155       - name: Cache NodeJS modules
    156         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    157         if: ${{ matrix.os != 'windows-latest' }}
    158         with:
    159           path: ~/.npm
    160           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     125          node-version-file: '.nvmrc'
     126          cache: npm
    161127
    162128      - name: Install Dependencies
     
    173139
    174140      - name: Clean after building in /src
    175         run: npm run grunt clean --dev
     141        run: npm run grunt clean -- --dev
     142
     143  slack-notifications:
     144    name: Slack Notifications
     145    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     146    needs: [ test-npm, test-npm-macos ]
     147    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     148    with:
     149      calling_status: ${{ needs.test-npm.result == 'success' && needs.test-npm-macos.result == 'success' && 'success' || ( needs.test-npm.result == 'cancelled' || needs.test-npm-macos.result == 'cancelled' ) && 'cancelled' || 'failure' }}
     150    secrets:
     151      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     152      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     153      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     154      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
  • branches/5.6/.github/workflows/welcome-new-contributors.yml

    r50602 r53599  
    99  post-welcome-message:
    1010    runs-on: ubuntu-latest
     11    timeout-minutes: 5
    1112    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
    1213
Note: See TracChangeset for help on using the changeset viewer.