Make WordPress Core

Changeset 53604


Ignore:
Timestamp:
06/30/2022 04:41:47 PM (2 years ago)
Author:
desrosj
Message:

Build/Test Tools: Use the Slack notifications workflow as a reusable one.

This backports several changesets that are required to remove the reliance on the workflow_run event for posting Slack notifications.

The Slack notification workflow will now be called as a reusable one, which has several benefits (see [53591]).

Several other minor GitHub Actions related updates are also being backported in this commit to maintain tooling consistency across branches that still receive security updates as a courtesy when necessary.

Workflows that are not relevant to this branch that were mistakenly backported are also being deleted.

Merges [50473], [50704], [50796], [50930], [51341], [51355], [51498], [51511], [51535], [51924], [51925], [51937], [52002], [52130], [52183], [52233], [53112], [53581], [53582], [53592] to the 5.1 branch.
See #56095.

Location:
branches/5.1
Files:
2 deleted
6 edited

Legend:

Unmodified
Added
Removed
  • branches/5.1

  • branches/5.1/.github/workflows/coding-standards.yml

    r50622 r53604  
    66  push:
    77    branches:
    8       - master
    98      - trunk
    109      - '3.[89]'
     
    1514  pull_request:
    1615    branches:
    17       - master
    1816      - trunk
    1917      - '3.[89]'
     
    3533  workflow_dispatch:
    3634
     35# Cancels all previous workflow runs for pull requests that have not completed.
     36concurrency:
     37  # The concurrency group contains the workflow name and the branch name for pull requests
     38  # or the commit hash for any other events.
     39  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     40  cancel-in-progress: true
     41
    3742jobs:
    3843  # Runs PHP coding standards checks.
     
    4954  # - Runs PHPCS on the full codebase with warnings suppressed.
    5055  # - Runs PHPCS on the `tests` directory without warnings suppressed.
    51   # - todo: Configure Slack notifications for failing scans.
    5256  phpcs:
    5357    name: PHP coding standards
     
    5761    steps:
    5862      - name: Checkout repository
    59         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     63        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    6064
    6165      - name: Set up PHP
    62         uses: shivammathur/setup-php@afefcaf556d98dc7896cca380e181decb609ca44 # v2.10.0
     66        uses: shivammathur/setup-php@3eda58347216592f618bb1dff277810b6698e4ca # v2.19.1
    6367        with:
    6468          php-version: '7.2'
     
    7276
    7377      - name: Install Composer dependencies
    74         uses: ramsey/composer-install@92a7904348d4ad30236f3611e33b7f0c6f9edd70 # v1.1.0
     78        uses: ramsey/composer-install@f680dac46551dffb2234a240d65ae806c2999dd6 # v2.1.0
    7579        with:
    7680          composer-options: "--no-progress --no-ansi --no-interaction"
     
    9195  # Performs the following steps:
    9296  # - Checks out the repository.
    93   # - Logs debug information about the runner container.
    94   # - Installs NodeJS 14.
    95   # - Sets up caching for NPM.
     97  # - Logs debug information about the GitHub Action runner.
     98  # - Installs NodeJS.
    9699  # - Logs updated debug information.
    97   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     100  # _ Installs NPM dependencies.
    98101  # - Run the WordPress JSHint checks.
    99   # - todo: Configure Slack notifications for failing tests.
    100102  jshint:
    101103    name: JavaScript coding standards
    102104    runs-on: ubuntu-latest
     105    timeout-minutes: 20
    103106    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    104107    env:
     
    107110    steps:
    108111      - name: Checkout repository
    109         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     112        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    110113
    111114      - name: Log debug information
     
    117120
    118121      - name: Install NodeJS
    119         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     122        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    120123        with:
    121           node-version: 14
    122 
    123       - name: Cache NodeJS modules
    124         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    125         env:
    126           cache-name: cache-node-modules
    127         with:
    128           # npm cache files are stored in `~/.npm` on Linux/macOS
    129           path: ~/.npm
    130           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     124          node-version-file: '.nvmrc'
     125          cache: npm
    131126
    132127      - name: Log debug information
     
    140135      - name: Run JSHint
    141136        run: npm run grunt jshint
     137
     138  slack-notifications:
     139    name: Slack Notifications
     140    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     141    needs: [ phpcs, jshint ]
     142    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     143    with:
     144      calling_status: ${{ needs.phpcs.result == 'success' && needs.jshint.result == 'success' && 'success' || ( needs.phpcs.result == 'cancelled' || needs.jshint.result == 'cancelled' ) && 'cancelled' || 'failure' }}
     145    secrets:
     146      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     147      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     148      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     149      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
  • branches/5.1/.github/workflows/javascript-tests.yml

    r50622 r53604  
    55  push:
    66    branches:
    7       - master
    87      - trunk
    98      - '3.[89]'
     
    1413  pull_request:
    1514    branches:
    16       - master
    1715      - trunk
    1816      - '3.[89]'
     
    3331  workflow_dispatch:
    3432
     33# Cancels all previous workflow runs for pull requests that have not completed.
     34concurrency:
     35  # The concurrency group contains the workflow name and the branch name for pull requests
     36  # or the commit hash for any other events.
     37  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     38  cancel-in-progress: true
     39
    3540jobs:
    3641  # Runs the QUnit tests for WordPress.
    3742  #
    3843  # Performs the following steps:
    39   # - Cancels all previous workflow runs for pull requests that have not completed.
    4044  # - Checks out the repository.
    41   # - Logs debug information about the runner container.
    42   # - Installs NodeJS 14.
    43   # - Sets up caching for NPM.
     45  # - Logs debug information about the GitHub Action runner.
     46  # - Installs NodeJS.
    4447  # - Logs updated debug information.
    45   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     48  # _ Installs NPM dependencies.
    4649  # - Run the WordPress QUnit tests.
    47   # - todo: Configure Slack notifications for failing tests.
    4850  test-js:
    4951    name: QUnit Tests
    5052    runs-on: ubuntu-latest
     53    timeout-minutes: 20
    5154    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    5255
    5356    steps:
    54       - name: Cancel previous runs of this workflow (pull requests only)
    55         if: ${{ github.event_name == 'pull_request' }}
    56         uses: styfle/cancel-workflow-action@3d86a7cc43670094ac248017207be0295edbc31d # v0.8.0
    57 
    5857      - name: Checkout repository
    59         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     58        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    6059
    6160      - name: Log debug information
     
    6766
    6867      - name: Install NodeJS
    69         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     68        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    7069        with:
    71           node-version: 14
    72 
    73       - name: Cache NodeJS modules
    74         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    75         env:
    76           cache-name: cache-node-modules
    77         with:
    78           # npm cache files are stored in `~/.npm` on Linux/macOS
    79           path: ~/.npm
    80           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     70          node-version-file: '.nvmrc'
     71          cache: npm
    8172
    8273      - name: Log debug information
     
    9081      - name: Run QUnit tests
    9182        run: npm run grunt qunit:compiled
     83
     84  slack-notifications:
     85    name: Slack Notifications
     86    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     87    needs: [ test-js ]
     88    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     89    with:
     90      calling_status: ${{ needs.test-js.result == 'success' && 'success' || needs.test-js.result == 'cancelled' && 'cancelled' || 'failure' }}
     91    secrets:
     92      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     93      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     94      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     95      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
  • branches/5.1/.github/workflows/phpunit-tests.yml

    r50622 r53604  
    44  push:
    55    branches:
    6       - master
    76      - trunk
    87      - '3.[7-9]'
     
    1312  pull_request:
    1413    branches:
    15       - master
    1614      - trunk
    1715      - '3.[7-9]'
     
    2119  schedule:
    2220    - cron: '0 0 * * 0'
     21
     22# Cancels all previous workflow runs for pull requests that have not completed.
     23concurrency:
     24    # The concurrency group contains the workflow name and the branch name for pull requests
     25    # or the commit hash for any other events.
     26  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     27  cancel-in-progress: true
    2328
    2429env:
     
    3742  # - Cancels all previous workflow runs for pull requests that have not completed.
    3843  # - Checks out the repository.
    39   # - Logs debug information about the runner container.
    40   # - Installs NodeJS 14.
    41   # - Sets up caching for NPM.
    42   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     44  # - Logs debug information about the GitHub Action runner.
     45  # - Installs NodeJS.
     46  # _ Installs NPM dependencies.
    4347  # - Builds WordPress to run from the `build` directory.
    4448  # - Creates a ZIP file of compiled WordPress.
     
    5054
    5155    steps:
    52       - name: Cancel previous runs of this workflow (pull requests only)
    53         if: ${{ github.event_name == 'pull_request' }}
    54         uses: styfle/cancel-workflow-action@3d86a7cc43670094ac248017207be0295edbc31d # v0.8.0
    55 
    5656      - name: Checkout repository
    57         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     57        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    5858
    5959      - name: Log debug information
     
    7171
    7272      - name: Install NodeJS
    73         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
    74         with:
    75           node-version: 14
    76 
    77       - name: Cache NodeJS modules
    78         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    79         env:
    80           cache-name: cache-node-modules
    81         with:
    82           # npm cache files are stored in `~/.npm` on Linux/macOS
    83           path: ~/.npm
    84           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     73        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
     74        with:
     75          node-version-file: '.nvmrc'
     76          cache: npm
    8577
    8678      - name: Install Dependencies
     
    9183
    9284      - name: Create ZIP artifact
    93         uses: thedoctor0/zip-release@a1afcab9c664c9976ac398fa831eac67bed1eb0e # v0.4.1
     85        uses: thedoctor0/zip-release@09336613be18a8208dfa66bd57efafd9e2685657 # v0.6.2
    9486        with:
    9587          filename: built-wp-${{ github.sha }}.zip
     
    9789
    9890      - name: Upload build artifact
    99         uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2.2.2
     91        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
    10092        with:
    10193          name: built-wp-${{ github.sha }}
     
    10698  #
    10799  # Performs the following steps:
    108   # - Set environment variables.
     100  # - Sets environment variables.
    109101  # - Sets up the environment variables needed for testing with memcached (if desired).
    110102  # - Downloads the built WordPress artifact from the previous job.
    111103  # - Unzips the artifact.
    112   # - Installs NodeJS 14.
    113   # - Sets up caching for NPM.
    114   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     104  # - Installs NodeJS.
     105  # _ Installs NPM dependencies.
    115106  # - Configures caching for Composer.
    116107  # _ Installs Composer dependencies (if desired).
    117   # - Logs Docker debug information (about both the Docker installation within the runner).
     108  # - Logs Docker debug information (about the Docker installation within the runner).
    118109  # - Starts the WordPress Docker container.
    119   # - Starts the memcached server after the Docker network has been created (if desired).
    120   # - Logs WordPress Docker container debug information.
    121   # - Logs debug general information.
     110  # - Starts the Memcached server after the Docker network has been created (if desired).
     111  # - Logs general debug information about the runner.
    122112  # - Logs the running Docker containers.
     113  # - Logs debug information from inside the WordPress Docker container.
    123114  # - Logs debug information about what's installed within the WordPress Docker containers.
    124115  # - Install WordPress within the Docker container.
     
    127118  # - Reconnect the directory to the Git repository.
    128119  # - Submit the test results to the WordPress.org host test results.
    129   # - todo: Configure Slack notifications for failing tests.
    130120  test-php:
    131     name: ${{ matrix.php }}${{ matrix.multisite && ' multisite' || '' }}${{ matrix.split_slow && ' slow tests' || '' }} ${{ matrix.memcached && ' with memcached' || '' }} on ${{ matrix.os }}
     121    name: ${{ matrix.php }}${{ matrix.multisite && ' multisite' || '' }}${{ matrix.split_slow && ' slow tests' || '' }}${{ matrix.memcached && ' with memcached' || '' }} on ${{ matrix.os }}
    132122    needs: setup-wordpress
    133123    runs-on: ${{ matrix.os }}
     124    timeout-minutes: 20
    134125    strategy:
    135126      fail-fast: false
     
    230221
    231222      - name: Download the built WordPress artifact
    232         uses: actions/download-artifact@4a7a711286f30c025902c28b541c10e147a9b843 # v2.0.8
     223        uses: actions/download-artifact@fb598a63ae348fa914e94cd0ff38f362e927b741 # v3.0.0
    233224        with:
    234225          name: built-wp-${{ github.sha }}
     
    238229
    239230      - name: Install NodeJS
    240         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
    241         with:
    242           node-version: 14
    243 
    244       - name: Use cached Node modules
    245         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    246         env:
    247           cache-name: cache-node-modules
    248         with:
    249           # npm cache files are stored in `~/.npm` on Linux/macOS
    250           path: ~/.npm
    251           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     231        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
     232        with:
     233          node-version-file: '.nvmrc'
     234          cache: npm
    252235
    253236      - name: Install Dependencies
     
    256239      - name: Cache Composer dependencies
    257240        if: ${{ env.COMPOSER_INSTALL == true }}
    258         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
     241        uses: actions/cache@c3f1317a9e7b1ef106c153ac8c0f00fed3ddbc0d # v3.0.4
    259242        env:
    260243          cache-name: cache-composer-dependencies
     
    336319
    337320      - name: Checkout the WordPress Test Reporter
    338         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/master' && matrix.report }}
    339         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     321        if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
     322        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    340323        with:
    341324          repository: 'WordPress/phpunit-test-runner'
     
    343326
    344327      - name: Set up the Git repository
    345         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/master' && matrix.report }}
     328        if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
    346329        run: |
    347330          git init
    348331          git remote add origin https://github.com/WordPress/wordpress-develop.git
    349332          git fetch
    350           git reset origin/master
     333          git reset origin/trunk
    351334
    352335      - name: Submit test results to the WordPress.org host test results
    353         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/master' && matrix.report }}
     336        if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
    354337        env:
    355338          WPT_REPORT_API_KEY: "${{ secrets.WPT_REPORT_API_KEY }}"
    356339        run: docker-compose run --rm -e WPT_REPORT_API_KEY -e WPT_PREPARE_DIR=/var/www -e WPT_TEST_DIR=/var/www php php test-runner/report.php
     340
     341  slack-notifications:
     342    name: Slack Notifications
     343    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     344    needs: [ setup-wordpress, test-php ]
     345    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     346    with:
     347      calling_status: ${{ needs.test-php.result == 'success' && 'success' || needs.test-php.result == 'cancelled' && 'cancelled' || 'failure' }}
     348    secrets:
     349      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     350      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     351      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     352      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
  • branches/5.1/.github/workflows/test-npm.yml

    r50622 r53604  
    44  push:
    55    branches:
    6       - master
    76      - trunk
    87      - '3.[7-9]'
     
    109  pull_request:
    1110    branches:
    12       - master
    1311      - trunk
    1412      - '3.[7-9]'
     
    2624  workflow_dispatch:
    2725
     26# Cancels all previous workflow runs for pull requests that have not completed.
     27concurrency:
     28  # The concurrency group contains the workflow name and the branch name for pull requests
     29  # or the commit hash for any other events.
     30  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     31  cancel-in-progress: true
     32
    2833env:
    2934  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
    3035
    3136jobs:
    32   # Prepares the workflow.
    33   #
    34   # Performs the following steps:
    35   # - Cancels all previous workflow runs for pull requests that have not completed.
    36   prepare-workflow:
    37     name: Prepare the workflow
    38     runs-on: ubuntu-latest
    39     if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    40 
    41     steps:
    42       - name: Cancel previous runs of this workflow (pull requests only)
    43         if: ${{ github.event_name == 'pull_request' }}
    44         uses: styfle/cancel-workflow-action@3d86a7cc43670094ac248017207be0295edbc31d # v0.8.0
    45 
    4637  # Verifies that installing NPM dependencies and building WordPress works as expected.
    4738  #
    4839  # Performs the following steps:
    4940  # - Checks out the repository.
    50   # - Logs debug information about the runner container.
    51   # - Installs NodeJS 14.
    52   # - Sets up caching for NPM.
    53   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     41  # - Logs debug information about the GitHub Action runner.
     42  # - Installs NodeJS.
     43  # _ Installs NPM dependencies.
    5444  # - Builds WordPress to run from the `build` directory.
    5545  # - Cleans up after building WordPress to the `build` directory.
     
    5949    name: Test NPM on ${{ matrix.os }}
    6050    runs-on: ${{ matrix.os }}
     51    timeout-minutes: 20
    6152    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    62     needs: prepare-workflow
    6353    strategy:
    6454      fail-fast: false
     
    6858    steps:
    6959      - name: Checkout repository
    70         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     60        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    7161
    7262      - name: Log debug information
     
    7969
    8070      - name: Install NodeJS
    81         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     71        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    8272        with:
    83           node-version: 14
    84 
    85       - name: Cache NodeJS modules (Ubuntu & MacOS)
    86         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    87         if: ${{ matrix.os != 'windows-latest' }}
    88         with:
    89           path: ~/.npm
    90           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
    91 
    92       - name: Get NPM cache directory (Windows only)
    93         if: ${{ matrix.os == 'windows-latest' }}
    94         id: npm-cache
    95         run: echo "::set-output name=dir::$(npm config get cache)"
    96 
    97       - name: Cache NodeJS modules (Windows only)
    98         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    99         if: ${{ matrix.os == 'windows-latest' }}
    100         with:
    101           path: ${{ steps.npm-cache.outputs.dir }}
    102           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     73          node-version-file: '.nvmrc'
     74          cache: npm
    10375
    10476      - name: Install Dependencies
     
    11587
    11688      - name: Clean after building in /src
    117         run: npm run grunt clean --dev
     89        run: npm run grunt clean -- --dev
    11890
    11991  # Verifies that installing NPM dependencies and building WordPress works as expected on MacOS.
    12092  #
    121   # This is a separate job in order to that more strict conditions can be used.
     93  # This is separate from the job above in order to use stricter conditions about when to run.
     94  # This avoids unintentionally consuming excessive minutes, as MacOS jobs consume minutes at a 10x rate.
    12295  #
    12396  # Performs the following steps:
    12497  # - Checks out the repository.
    125   # - Logs debug information about the runner container.
    126   # - Installs NodeJS 14.
    127   # - Sets up caching for NPM.
    128   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     98  # - Logs debug information about the GitHub Action runner.
     99  # - Installs NodeJS.
     100  # _ Installs NPM dependencies.
    129101  # - Builds WordPress to run from the `build` directory.
    130102  # - Cleans up after building WordPress to the `build` directory.
     
    134106    name: Test NPM on MacOS
    135107    runs-on: macos-latest
     108    timeout-minutes: 20
    136109    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
    137     needs: prepare-workflow
    138110    steps:
    139111      - name: Checkout repository
    140         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     112        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    141113
    142114      - name: Log debug information
     
    149121
    150122      - name: Install NodeJS
    151         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     123        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    152124        with:
    153           node-version: 14
    154 
    155       - name: Cache NodeJS modules
    156         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    157         if: ${{ matrix.os != 'windows-latest' }}
    158         with:
    159           path: ~/.npm
    160           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     125          node-version-file: '.nvmrc'
     126          cache: npm
    161127
    162128      - name: Install Dependencies
     
    173139
    174140      - name: Clean after building in /src
    175         run: npm run grunt clean --dev
     141        run: npm run grunt clean -- --dev
     142
     143  slack-notifications:
     144    name: Slack Notifications
     145    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     146    needs: [ test-npm, test-npm-macos ]
     147    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     148    with:
     149      calling_status: ${{ needs.test-npm.result == 'success' && needs.test-npm-macos.result == 'success' && 'success' || ( needs.test-npm.result == 'cancelled' || needs.test-npm-macos.result == 'cancelled' ) && 'cancelled' || 'failure' }}
     150    secrets:
     151      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     152      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     153      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     154      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
  • branches/5.1/.github/workflows/welcome-new-contributors.yml

    r50622 r53604  
    99  post-welcome-message:
    1010    runs-on: ubuntu-latest
     11    timeout-minutes: 5
    1112    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
    1213
Note: See TracChangeset for help on using the changeset viewer.