WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
06/30/2022 05:21:21 PM (3 years ago)
Author:
desrosj
Message:

Build/Test Tools: Use the Slack notifications workflow as a reusable one.

This backports several changesets that are required to remove the reliance on the workflow_run event for posting Slack notifications.

The Slack notification workflow will now be called as a reusable one, which has several benefits (see [53591]).

Several other minor GitHub Actions related updates are also being backported in this commit to maintain tooling consistency across branches that still receive security updates as a courtesy when necessary.

Workflows that are not relevant to this branch that were mistakenly backported are also being deleted.

Merges [50473], [50704], [50930], [51341], [51355], [51498], [51511], [51535], [51924], [51925], [51937], [52002], [52130], [52183], [52233], [53112], [53581], [53582], [53592] to the 4.2 branch.
See #56095.

Location:
branches/4.2
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • branches/4.2

  • branches/4.2/.github/workflows/test-npm.yml

    r50642 r53619  
    44  push:
    55    branches:
    6       - master
    76      - trunk
    87      - '3.[7-9]'
    … …  
    109  pull_request:
    1110    branches:
    12       - master
    1311      - trunk
    1412      - '3.[7-9]'
    … …  
    2624  workflow_dispatch:
    2725
     26# Cancels all previous workflow runs for pull requests that have not completed.
     27concurrency:
     28  # The concurrency group contains the workflow name and the branch name for pull requests
     29  # or the commit hash for any other events.
     30  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     31  cancel-in-progress: true
     32
    2833env:
    2934  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
    3035
    3136jobs:
    32   # Prepares the workflow.
    33   #
    34   # Performs the following steps:
    35   # - Cancels all previous workflow runs for pull requests that have not completed.
    36   prepare-workflow:
    37     name: Prepare the workflow
    38     runs-on: ubuntu-latest
    39     if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    40 
    41     steps:
    42       - name: Cancel previous runs of this workflow (pull requests only)
    43         if: ${{ github.event_name == 'pull_request' }}
    44         uses: styfle/cancel-workflow-action@3d86a7cc43670094ac248017207be0295edbc31d # v0.8.0
    45 
    4637  # Verifies that installing NPM dependencies and building WordPress works as expected.
    4738  #
    4839  # Performs the following steps:
    4940  # - Checks out the repository.
    50   # - Logs debug information about the runner container.
    51   # - Installs NodeJS 14.
    52   # - Sets up caching for NPM.
    53   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     41  # - Logs debug information about the GitHub Action runner.
     42  # - Installs NodeJS.
     43  # _ Installs NPM dependencies.
    5444  # - Builds WordPress to run from the `build` directory.
    5545  # - Cleans up after building WordPress to the `build` directory.
    … …  
    5747    name: Test NPM on ${{ matrix.os }}
    5848    runs-on: ${{ matrix.os }}
     49    timeout-minutes: 20
    5950    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    60     needs: prepare-workflow
    6151    strategy:
    6252      fail-fast: false
    … …  
    6656    steps:
    6757      - name: Checkout repository
    68         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     58        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    6959
    7060      - name: Log debug information
    … …  
    7767
    7868      - name: Install NodeJS
    79         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     69        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    8070        with:
    81           node-version: 14
    82 
    83       - name: Cache NodeJS modules (Ubuntu & MacOS)
    84         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    85         if: ${{ matrix.os != 'windows-latest' }}
    86         with:
    87           path: ~/.npm
    88           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
    89 
    90       - name: Get NPM cache directory (Windows only)
    91         if: ${{ matrix.os == 'windows-latest' }}
    92         id: npm-cache
    93         run: echo "::set-output name=dir::$(npm config get cache)"
    94 
    95       - name: Cache NodeJS modules (Windows only)
    96         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    97         if: ${{ matrix.os == 'windows-latest' }}
    98         with:
    99           path: ${{ steps.npm-cache.outputs.dir }}
    100           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     71          node-version-file: '.nvmrc'
     72          cache: npm
    10173
    10274      - name: Install Dependencies
    … …  
    11183  # Verifies that installing NPM dependencies and building WordPress works as expected on MacOS.
    11284  #
    113   # This is a separate job in order to that more strict conditions can be used.
     85  # This is separate from the job above in order to use stricter conditions about when to run.
     86  # This avoids unintentionally consuming excessive minutes, as MacOS jobs consume minutes at a 10x rate.
    11487  #
    11588  # Performs the following steps:
    11689  # - Checks out the repository.
    117   # - Logs debug information about the runner container.
    118   # - Installs NodeJS 14.
    119   # - Sets up caching for NPM.
    120   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     90  # - Logs debug information about the GitHub Action runner.
     91  # - Installs NodeJS.
     92  # _ Installs NPM dependencies.
    12193  # - Builds WordPress to run from the `build` directory.
    12294  # - Cleans up after building WordPress to the `build` directory.
    … …  
    12597    runs-on: macos-latest
    12698    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
    127     needs: prepare-workflow
    12899    steps:
    129100      - name: Checkout repository
    130         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     101        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    131102
    132103      - name: Log debug information
    … …  
    139110
    140111      - name: Install NodeJS
    141         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     112        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    142113        with:
    143           node-version: 14
    144 
    145       - name: Cache NodeJS modules
    146         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    147         if: ${{ matrix.os != 'windows-latest' }}
    148         with:
    149           path: ~/.npm
    150           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     114          node-version-file: '.nvmrc'
     115          cache: npm
    151116
    152117      - name: Install Dependencies
    … …  
    158123      - name: Clean after building
    159124        run: npm run grunt clean
     125
     126  slack-notifications:
     127    name: Slack Notifications
     128    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     129    needs: [ test-npm, test-npm-macos ]
     130    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     131    with:
     132      calling_status: ${{ needs.test-npm.result == 'success' && needs.test-npm-macos.result == 'success' && 'success' || ( needs.test-npm.result == 'cancelled' || needs.test-npm-macos.result == 'cancelled' ) && 'cancelled' || 'failure' }}
     133    secrets:
     134      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     135      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     136      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     137      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
Note: See TracChangeset for help on using the changeset viewer.