WordPress.org
Get WordPress

Make WordPress Core

Changeset 53624


Ignore:
Timestamp:
06/30/2022 05:30:48 PM (3 years ago)
Author:
desrosj
Message:

Build/Test Tools: Use the Slack notifications workflow as a reusable one.

This backports several changesets that are required to remove the reliance on the workflow_run event for posting Slack notifications.

The Slack notification workflow will now be called as a reusable one, which has several benefits (see [53591]).

Several other minor GitHub Actions related updates are also being backported in this commit to maintain tooling consistency across branches that still receive security updates as a courtesy when necessary.

Workflows that are not relevant to this branch that were mistakenly backported are also being deleted.

Merges [50473], [50704], [50930], [51341], [51355], [51498], [51511], [51535], [51924], [51925], [51937], [52002], [52130], [52183], [52233], [53112], [53581], [53582], [53592] to the 3.7 branch.
See #56095.

Location:
branches/3.7
Files:
4 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • branches/3.7

  • branches/3.7/.github/workflows/coding-standards.yml

    r50626 r53624  
    9494  # Performs the following steps:
    9595  # - Checks out the repository.
    96   # - Logs debug information about the runner container.
    97   # - Installs NodeJS 14.
     96  # - Logs debug information about the GitHub Action runner.
     97  # - Installs NodeJS.
    9898  # - Sets up caching for NPM.
    9999  # - Logs updated debug information.
    100   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     100  # _ Installs NPM dependencies.
    101101  # - Run the WordPress JSHint checks.
    102   # - todo: Configure Slack notifications for failing tests.
    103102  jshint:
    104103    name: JavaScript coding standards

  • branches/3.7/.github/workflows/phpunit-tests.yml

    r50626 r53624  
    44  push:
    55    branches:
    6       - master
    76      - trunk
    87      - '3.[7-9]'
    … …  
    1312  pull_request:
    1413    branches:
    15       - master
    1614      - trunk
    1715      - '3.[7-9]'
    … …  
    2119  schedule:
    2220    - cron: '0 0 * * 0'
     21
     22# Cancels all previous workflow runs for pull requests that have not completed.
     23concurrency:
     24    # The concurrency group contains the workflow name and the branch name for pull requests
     25    # or the commit hash for any other events.
     26  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     27  cancel-in-progress: true
    2328
    2429env:
    … …  
    3742  # - Cancels all previous workflow runs for pull requests that have not completed.
    3843  # - Checks out the repository.
    39   # - Logs debug information about the runner container.
    40   # - Installs NodeJS 14.
    41   # - Sets up caching for NPM.
    42   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     44  # - Logs debug information about the GitHub Action runner.
     45  # - Installs NodeJS.
     46  # _ Installs NPM dependencies.
    4347  # - Builds WordPress to run from the `build` directory.
    4448  # - Creates a ZIP file of compiled WordPress.
    … …  
    5054
    5155    steps:
    52       - name: Cancel previous runs of this workflow (pull requests only)
    53         if: ${{ github.event_name == 'pull_request' }}
    54         uses: styfle/cancel-workflow-action@3d86a7cc43670094ac248017207be0295edbc31d # v0.8.0
    55 
    5656      - name: Checkout repository
    57         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     57        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    5858
    5959      - name: Log debug information
    … …  
    7171
    7272      - name: Install NodeJS
    73         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
    74         with:
    75           node-version: 14
    76 
    77       - name: Cache NodeJS modules
    78         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    79         env:
    80           cache-name: cache-node-modules
    81         with:
    82           # npm cache files are stored in `~/.npm` on Linux/macOS
    83           path: ~/.npm
    84           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     73        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
     74        with:
     75          node-version-file: '.nvmrc'
     76          cache: npm
    8577
    8678      - name: Install Dependencies
    … …  
    9183
    9284      - name: Create ZIP artifact
    93         uses: thedoctor0/zip-release@a1afcab9c664c9976ac398fa831eac67bed1eb0e # v0.4.1
     85        uses: thedoctor0/zip-release@09336613be18a8208dfa66bd57efafd9e2685657 # v0.6.2
    9486        with:
    9587          filename: built-wp-${{ github.sha }}.zip
    … …  
    9789
    9890      - name: Upload build artifact
    99         uses: actions/upload-artifact@e448a9b857ee2131e752b06002bf0e093c65e571 # v2.2.2
     91        uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
    10092        with:
    10193          name: built-wp-${{ github.sha }}
    … …  
    10698  #
    10799  # Performs the following steps:
    108   # - Set environment variables.
     100  # - Sets environment variables.
    109101  # - Sets up the environment variables needed for testing with memcached (if desired).
    110102  # - Downloads the built WordPress artifact from the previous job.
    111103  # - Unzips the artifact.
    112   # - Installs NodeJS 14.
    113   # - Sets up caching for NPM.
    114   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     104  # - Installs NodeJS.
     105  # _ Installs NPM dependencies.
    115106  # - Configures caching for Composer.
    116107  # _ Installs Composer dependencies (if desired).
    117   # - Logs Docker debug information (about both the Docker installation within the runner).
     108  # - Logs Docker debug information (about the Docker installation within the runner).
    118109  # - Starts the WordPress Docker container.
    119   # - Starts the memcached server after the Docker network has been created (if desired).
    120   # - Logs WordPress Docker container debug information.
    121   # - Logs debug general information.
     110  # - Starts the Memcached server after the Docker network has been created (if desired).
     111  # - Logs general debug information about the runner.
    122112  # - Logs the running Docker containers.
     113  # - Logs debug information from inside the WordPress Docker container.
    123114  # - Logs debug information about what's installed within the WordPress Docker containers.
    124115  # - Install WordPress within the Docker container.
    … …  
    127118  # - Reconnect the directory to the Git repository.
    128119  # - Submit the test results to the WordPress.org host test results.
    129   # - todo: Configure Slack notifications for failing tests.
    130120  test-php:
    131     name: ${{ matrix.php }}${{ matrix.multisite && ' multisite' || '' }}${{ matrix.split_slow && ' slow tests' || '' }} ${{ matrix.memcached && ' with memcached' || '' }} on ${{ matrix.os }}
     121    name: ${{ matrix.php }}${{ matrix.multisite && ' multisite' || '' }}${{ matrix.split_slow && ' slow tests' || '' }}${{ matrix.memcached && ' with memcached' || '' }} on ${{ matrix.os }}
    132122    needs: setup-wordpress
    133123    runs-on: ${{ matrix.os }}
     124    timeout-minutes: 20
    134125    strategy:
    135126      fail-fast: false
    … …  
    151142
    152143      - name: Download the built WordPress artifact
    153         uses: actions/download-artifact@4a7a711286f30c025902c28b541c10e147a9b843 # v2.0.8
     144        uses: actions/download-artifact@fb598a63ae348fa914e94cd0ff38f362e927b741 # v3.0.0
    154145        with:
    155146          name: built-wp-${{ github.sha }}
    … …  
    159150
    160151      - name: Install NodeJS
    161         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
    162         with:
    163           node-version: 14
    164 
    165       - name: Use cached Node modules
    166         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    167         env:
    168           cache-name: cache-node-modules
    169         with:
    170           # npm cache files are stored in `~/.npm` on Linux/macOS
    171           path: ~/.npm
    172           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     152        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
     153        with:
     154          node-version-file: '.nvmrc'
     155          cache: npm
    173156
    174157      - name: Install Dependencies
    … …  
    177160      - name: Cache Composer dependencies
    178161        if: ${{ env.COMPOSER_INSTALL == true }}
    179         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
     162        uses: actions/cache@c3f1317a9e7b1ef106c153ac8c0f00fed3ddbc0d # v3.0.4
    180163        env:
    181164          cache-name: cache-composer-dependencies
    … …  
    253236
    254237      - name: Checkout the WordPress Test Reporter
    255         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/master' && matrix.report }}
    256         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     238        if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
     239        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    257240        with:
    258241          repository: 'WordPress/phpunit-test-runner'
    … …  
    260243
    261244      - name: Set up the Git repository
    262         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/master' && matrix.report }}
     245        if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
    263246        run: |
    264247          git init
    265248          git remote add origin https://github.com/WordPress/wordpress-develop.git
    266249          git fetch
    267           git reset origin/master
     250          git reset origin/trunk
    268251
    269252      - name: Submit test results to the WordPress.org host test results
    270         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/master' && matrix.report }}
     253        if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
    271254        env:
    272255          WPT_REPORT_API_KEY: "${{ secrets.WPT_REPORT_API_KEY }}"
    273256        run: docker-compose run --rm -e WPT_REPORT_API_KEY -e WPT_PREPARE_DIR=/var/www -e WPT_TEST_DIR=/var/www php php test-runner/report.php
     257
     258  slack-notifications:
     259    name: Slack Notifications
     260    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     261    needs: [ setup-wordpress, test-php ]
     262    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     263    with:
     264      calling_status: ${{ needs.test-php.result == 'success' && 'success' || needs.test-php.result == 'cancelled' && 'cancelled' || 'failure' }}
     265    secrets:
     266      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     267      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     268      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     269      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}

  • branches/3.7/.github/workflows/test-npm.yml

    r50626 r53624  
    44  push:
    55    branches:
    6       - master
    76      - trunk
    87      - '3.[7-9]'
    … …  
    109  pull_request:
    1110    branches:
    12       - master
    1311      - trunk
    1412      - '3.[7-9]'
    … …  
    2624  workflow_dispatch:
    2725
     26# Cancels all previous workflow runs for pull requests that have not completed.
     27concurrency:
     28    # The concurrency group contains the workflow name and the branch name for pull requests
     29    # or the commit hash for any other events.
     30  group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
     31  cancel-in-progress: true
     32
    2833env:
    2934  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
    3035
    3136jobs:
    32   # Prepares the workflow.
    33   #
    34   # Performs the following steps:
    35   # - Cancels all previous workflow runs for pull requests that have not completed.
    36   prepare-workflow:
    37     name: Prepare the workflow
    38     runs-on: ubuntu-latest
    39     if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    40 
    41     steps:
    42       - name: Cancel previous runs of this workflow (pull requests only)
    43         if: ${{ github.event_name == 'pull_request' }}
    44         uses: styfle/cancel-workflow-action@3d86a7cc43670094ac248017207be0295edbc31d # v0.8.0
    45 
    4637  # Verifies that installing NPM dependencies and building WordPress works as expected.
    4738  #
    4839  # Performs the following steps:
    4940  # - Checks out the repository.
    50   # - Logs debug information about the runner container.
    51   # - Installs NodeJS 14.
     41  # - Logs debug information about the GitHub Action runner.
     42  # - Installs NodeJS.
    5243  # - Sets up caching for NPM.
    53   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     44  # _ Installs NPM dependencies.
    5445  # - Builds WordPress to run from the `build` directory.
    5546  # - Cleans up after building WordPress to the `build` directory.
    … …  
    5748    name: Test NPM on ${{ matrix.os }}
    5849    runs-on: ${{ matrix.os }}
     50    timeout-minutes: 20
    5951    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    60     needs: prepare-workflow
    6152    strategy:
    6253      matrix:
    … …  
    6556    steps:
    6657      - name: Checkout repository
    67         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     58        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    6859
    6960      - name: Log debug information
    … …  
    7667
    7768      - name: Install NodeJS
    78         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     69        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    7970        with:
    80           node-version: 14
    81 
    82       - name: Cache NodeJS modules (Ubuntu & MacOS)
    83         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    84         if: ${{ matrix.os != 'windows-latest' }}
    85         with:
    86           path: ~/.npm
    87           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
    88 
    89       - name: Get NPM cache directory (Windows only)
    90         if: ${{ matrix.os == 'windows-latest' }}
    91         id: npm-cache
    92         run: echo "::set-output name=dir::$(npm config get cache)"
    93 
    94       - name: Cache NodeJS modules (Windows only)
    95         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    96         if: ${{ matrix.os == 'windows-latest' }}
    97         with:
    98           path: ${{ steps.npm-cache.outputs.dir }}
    99           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     71          node-version-file: '.nvmrc'
     72          cache: npm
    10073
    10174      - name: Install Dependencies
    … …  
    11083  # Verifies that installing NPM dependencies and building WordPress works as expected on MacOS.
    11184  #
    112   # This is a separate job in order to that more strict conditions can be used.
     85  # This is separate from the job above in order to use stricter conditions about when to run.
     86  # This avoids unintentionally consuming excessive minutes, as MacOS jobs consume minutes at a 10x rate.
    11387  #
    11488  # Performs the following steps:
    11589  # - Checks out the repository.
    116   # - Logs debug information about the runner container.
    117   # - Installs NodeJS 14.
    118   # - Sets up caching for NPM.
    119   # _ Installs NPM dependencies using install-changed to hash the `package.json` file.
     90  # - Logs debug information about the GitHub Action runner.
     91  # - Installs NodeJS.
     92  # _ Installs NPM dependencies.
    12093  # - Builds WordPress to run from the `build` directory.
    12194  # - Cleans up after building WordPress to the `build` directory.
    … …  
    12497    runs-on: macos-latest
    12598    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
    126     needs: prepare-workflow
    12799    steps:
    128100      - name: Checkout repository
    129         uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f # v2.3.4
     101        uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
    130102
    131103      - name: Log debug information
    … …  
    138110
    139111      - name: Install NodeJS
    140         uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea # v2.1.5
     112        uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
    141113        with:
    142           node-version: 14
    143 
    144       - name: Cache NodeJS modules
    145         uses: actions/cache@26968a09c0ea4f3e233fdddbafd1166051a095f6 # v2.1.4
    146         if: ${{ matrix.os != 'windows-latest' }}
    147         with:
    148           path: ~/.npm
    149           key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
     114          node-version-file: '.nvmrc'
     115          cache: npm
    150116
    151117      - name: Install Dependencies
    … …  
    157123      - name: Clean after building
    158124        run: npm run grunt clean
     125
     126  slack-notifications:
     127    name: Slack Notifications
     128    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     129    needs: [ test-npm, test-npm-macos ]
     130    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
     131    with:
     132      calling_status: ${{ needs.test-npm.result == 'success' && needs.test-npm-macos.result == 'success' && 'success' || ( needs.test-npm.result == 'cancelled' || needs.test-npm-macos.result == 'cancelled' ) && 'cancelled' || 'failure' }}
     133    secrets:
     134      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
     135      SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
     136      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
     137      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}

  • branches/3.7/.github/workflows/welcome-new-contributors.yml

    r50626 r53624  
    99  post-welcome-message:
    1010    runs-on: ubuntu-latest
     11    timeout-minutes: 5
    1112    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
    1213
Note: See TracChangeset for help on using the changeset viewer.