Changeset 53630

Timestamp:

07/01/2022 07:59:38 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Widgets: Add a comment in WP_Nav_Menu_Widget::form() to clarify the esc_attr() usage.

The URL to create a new menu from the the Navigation Menu widget can be a javascript: link to the Customizer Menus panel, so esc_attr() is used here instead of esc_url().

Follow-up to [53092].

Props hztyfoon.
Fixes #56128.

File:

• trunk/src/wp-includes/widgets/class-wp-nav-menu-widget.php (modified) (1 diff)

trunk/src/wp-includes/widgets/class-wp-nav-menu-widget.php

@@ -172 +172 @@
             }
 
-            /* translators: %s: URL to create a new menu. */
-            printf( __( 'No menus have been created yet. <a href="%s">Create some</a>.' ), esc_attr( $url ) );
+            printf(
+                /* translators: %s: URL to create a new menu. */
+                __( 'No menus have been created yet. <a href="%s">Create some</a>.' ),
+                // The URL can be a `javascript:` link, so esc_attr() is used here instead of esc_url().
+                esc_attr( $url )
+            );
             ?>
         </p>