Changeset 53655 for trunk/tests/phpunit/tests/user/query.php

Timestamp:

07/05/2022 09:26:21 AM (15 months ago)

Author:

spacedmonkey

Message:

Users: Prime user meta in WP_User_Query class.

When querying 'fields' equal to 'all' using the WP_User_Query class, this returns an array of WP_User objects. A WP_User object requires user meta to be primed, as the user's role is stored in user meta. Ensure that all users meta is primed in a single request by calling the cache_users function when querying 'fields' equal to 'all'. Soft deprecate fields equal to all_with_meta as it now acts the same as 'fields' equal to 'all'.

Props Spacedmonkey, peterwilsoncc, mehulkaklotar, timothyblynjacobs, furi3r.
Fixes #55594.

File:

• trunk/tests/phpunit/tests/user/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/user/query.php

@@ -154 +154 @@
             $this->assertInstanceOf( 'WP_User', $user );
         }
+    }
+
+    /**
+     * @ticket 55594
+     */
+    public function test_get_all_primed_users() {
+        $filter = new MockAction();
+        add_filter( 'update_user_metadata_cache', array( $filter, 'filter' ), 10, 2 );
+
+        new WP_User_Query(
+            array(
+                'include' => self::$author_ids,
+                'fields'  => 'all',
+            )
+        );
+
+        $args      = $filter->get_args();
+        $last_args = end( $args );
+        $this->assertIsArray( $last_args[1] );
+        $this->assertSameSets( self::$author_ids, $last_args[1], 'Ensure that user meta is primed' );
     }