Changeset 53669

Timestamp:

07/06/2022 05:09:22 AM (2 years ago)

Author:

peterwilsoncc

Message:

Taxonomy: Retain default term option when unregistering taxos.

No longer delete the default term option in unregister_taxonomy() to improve database performance.

Since taxonomies are registered at runtime and can't be unregistered unless they're already registered, prior to this
change the option was created and deleted on each request.

Deleting the option should occur on a one-time opperation such as plugin deactivation.

Follow up to [48480].

Props dlh.
Fixes #54472.

Location:

trunk

Files:

• src/wp-includes/taxonomy.php (modified) (1 diff)
• tests/phpunit/tests/taxonomy.php (modified) (1 diff)

trunk/src/wp-includes/taxonomy.php

@@ -580 +580 @@
     $taxonomy_object->remove_rewrite_rules();
     $taxonomy_object->remove_hooks();
-
-    // Remove custom taxonomy default term option.
-    if ( ! empty( $taxonomy_object->default_term ) ) {
-        delete_option( 'default_term_' . $taxonomy_object->name );
-    }
 
     // Remove the taxonomy.

trunk/tests/phpunit/tests/taxonomy.php

@@ -1045 +1045 @@
         $term = wp_get_post_terms( $post_id, $tax );
         $this->assertSame( array(), $term );
-
-        unregister_taxonomy( $tax );
-        $this->assertSame( get_option( 'default_term_' . $tax ), false );
     }