Changeset 53714

Timestamp:

07/17/2022 02:16:27 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use MINUTE_IN_SECONDS where appropriate.

This aims to clarify the time units for some timeout or expiration values.

Follow-up to [11823], [13177], [21996], [37747].

See #55647.

Location:

trunk/src/wp-admin

Files:

• includes/class-wp-filesystem-ftpext.php (modified) (1 diff)
• includes/file.php (modified) (1 diff)
• options-permalink.php (modified) (1 diff)
• options.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-filesystem-ftpext.php

@@ -41 +41 @@
         // This class uses the timeout on a per-connection basis, others use it on a per-action basis.
         if ( ! defined( 'FS_TIMEOUT' ) ) {
-            define( 'FS_TIMEOUT', 240 );
+            define( 'FS_TIMEOUT', 4 * MINUTE_IN_SECONDS );
         }
 

trunk/src/wp-admin/includes/file.php

@@ -2008 +2008 @@
      */
     if ( ! defined( 'FS_CONNECT_TIMEOUT' ) ) {
-        define( 'FS_CONNECT_TIMEOUT', 30 );
+        define( 'FS_CONNECT_TIMEOUT', MINUTE_IN_SECONDS / 2 );
     }
     if ( ! defined( 'FS_TIMEOUT' ) ) {
-        define( 'FS_TIMEOUT', 30 );
+        define( 'FS_TIMEOUT', MINUTE_IN_SECONDS / 2 );
     }
 

trunk/src/wp-admin/options-permalink.php

@@ -204 +204 @@
     }
 
-    set_transient( 'settings_errors', get_settings_errors(), 30 );
+    set_transient( 'settings_errors', get_settings_errors(), MINUTE_IN_SECONDS / 2 );
 
     wp_redirect( admin_url( 'options-permalink.php?settings-updated=true' ) );

trunk/src/wp-admin/options.php

@@ -345 +345 @@
         add_settings_error( 'general', 'settings_updated', __( 'Settings saved.' ), 'success' );
     }
-    set_transient( 'settings_errors', get_settings_errors(), 30 );
+
+    set_transient( 'settings_errors', get_settings_errors(), MINUTE_IN_SECONDS / 2 );
 
     // Redirect back to the settings page that was submitted.