Changeset 53760 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

Timestamp:

07/22/2022 01:58:46 PM (4 years ago)

Author:

spacedmonkey

Message:

REST API: Avoid unnecessarily preparing item links.

Do not call the prepare_links methods in core REST API controllers, unless the _links or _embedded fields are requested. There is no need to prepare links if they are never returned in the response. This saves resources, as many calls to prepare_links methods perform database queries.

Props Spacedmonkey, timothyblynjacobs, rachelbaker, desrosj, dlh, hellofromTonya.
Fixes #52992.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-controller.php

@@ -582 +582 @@
                 $fields = array_keys( $properties );
 
+                /*
+                 * '_links' and '_embedded' are not typically part of the item schema,
+                 * but they can be specified in '_fields', so they are added here as a
+                 * convenience for checking with rest_is_field_included().
+                 */
+                $fields[] = '_links';
+                if ( $request->has_param( '_embed' ) ) {
+                        $fields[] = '_embedded';
+                }
+
+                $fields = array_unique( $fields );
+
                 if ( ! isset( $request['_fields'] ) ) {
                         return $fields;