Changeset 53760 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php

Timestamp:

07/22/2022 01:58:46 PM (4 years ago)

Author:

spacedmonkey

Message:

REST API: Avoid unnecessarily preparing item links.

Do not call the prepare_links methods in core REST API controllers, unless the _links or _embedded fields are requested. There is no need to prepare links if they are never returned in the response. This saves resources, as many calls to prepare_links methods perform database queries.

Props Spacedmonkey, timothyblynjacobs, rachelbaker, desrosj, dlh, hellofromTonya.
Fixes #52992.

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php

@@ -393 +393 @@
                 $response = rest_ensure_response( $data );
 
-                $links = $this->prepare_links( $post->ID );
-                $response->add_links( $links );
-                if ( ! empty( $links['self']['href'] ) ) {
-                        $actions = $this->get_available_actions();
-                        $self    = $links['self']['href'];
-                        foreach ( $actions as $rel ) {
-                                $response->add_link( $rel, $self );
+                if ( rest_is_field_included( '_links', $fields ) || rest_is_field_included( '_embedded', $fields ) ) {
+                        $links = $this->prepare_links( $post->ID );
+                        $response->add_links( $links );
+                        if ( ! empty( $links['self']['href'] ) ) {
+                                $actions = $this->get_available_actions();
+                                $self    = $links['self']['href'];
+                                foreach ( $actions as $rel ) {
+                                        $response->add_link( $rel, $self );
+                                }
                         }
                 }
@@ -591 +593 @@
                 $response = rest_ensure_response( $data );
 
-                $links = array(
-                        'self' => array(
-                                'href' => rest_url( sprintf( '%s/%s/themes/%s', $this->namespace, $this->rest_base, $request['stylesheet'] ) ),
-                        ),
-                );
-
-                $response->add_links( $links );
+                if ( rest_is_field_included( '_links', $fields ) || rest_is_field_included( '_embedded', $fields ) ) {
+                        $links = array(
+                                'self' => array(
+                                        'href' => rest_url( sprintf( '%s/%s/themes/%s', $this->namespace, $this->rest_base, $request['stylesheet'] ) ),
+                                ),
+                        );
+                        $response->add_links( $links );
+                }
 
                 return $response;